drivers: Add GPIO driver for BCM2711 (Raspberry Pi 4B) #63323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* defconfig is located under `boards/arm64/` instead of `boards/arm/` * 64-bit mode (`arm_64bit=1`) is required to boot Signed-off-by: Chen Xingyu <[email protected]>
xingrz
requested review from
nashif,
galak,
carlocaione and
mnkp
as code owners
zephyrbot
added
area: GPIO
area: Devicetree Binding
zephyrbot
requested review from
henrikbrixandersen,
npitre,
povergoing and
SgrrZhf
xingrz
force-pushed
the
rpi4b-gpio
branch
4 times, most recently
from
1021588 to
5007722
Compare
xingrz
force-pushed
the
rpi4b-gpio
branch
3 times, most recently
from
5b394c9 to
b383829
Compare
xingrz
changed the title
gmarull
requested changes
Oct 4, 2023
drivers/gpio/gpio_bcm2711.c
Outdated
Comment on lines
293
to
302
| static int uart_bcm2711_controller_init(void) | ||
| { | ||
| IRQ_CONNECT(DT_IRQN(GPIO_BCM2711_CONTROLLER), DT_IRQ(GPIO_BCM2711_CONTROLLER, priority), | ||
| uart_bcm2711_controller_isr, NULL, 0); | ||
| irq_enable(DT_IRQN(GPIO_BCM2711_CONTROLLER)); | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| SYS_INIT(uart_bcm2711_controller_init, PRE_KERNEL_1, CONFIG_GPIO_INIT_PRIORITY); |
There was a problem hiding this comment.
If I read this correctly, SYS_INIT is not required, just define this function as part of the device definition macro and call it during driver init, there are quite a few examples in tree
There was a problem hiding this comment.
As I explained in the commit message, the two instances of GPIO devices share the same IRQ. To the best of my knowledge, only one ISR function can be connected to a specific IRQ.
So the idea here is to register a 'shared' ISR function in case either one or both GPIO instances are enabled. This separate SYS_INIT function is responsible for handling the registration job.
There was a problem hiding this comment.
Zephyr recently gained support for shared IRQ, please see commit 017cf89.
There was a problem hiding this comment.
It's strange that shared IRQ causes the applicaton hangs at *** Booti. I'm investigating the problem.
xingrz
changed the title
xingrz
changed the title
gmarull
previously approved these changes
Oct 9, 2023
|
Just found some issues on tests. I'll update later. |
xingrz
force-pushed
the
rpi4b-gpio
branch
5 times, most recently
from
9424d40 to
5fa27b2
Compare
|
Updated. It's ready now. |
Keep aligned with `rpi_pico` board. Signed-off-by: Chen Xingyu <[email protected]>
No reason to declare it per node, as it is almostly shared by all peripherals. Also introduced `DT_FREQ_M` macro for better readability. Signed-off-by: Chen Xingyu <[email protected]>
The BCM2711 SoC exposes 58 GPIOs. The first 28 (bank 0) are accessible to users via the 40-pin header, while the others (bank 1) are used for controlling on-board peripherals. This also update doc of `rpi_4b` board. Signed-off-by: Chen Xingyu <[email protected]>
LED_ACT is the green LED at the top left corner of the RPi 4B board. Signed-off-by: Chen Xingyu <[email protected]>
Rewrote with a more detailed procedure. Signed-off-by: Chen Xingyu <[email protected]>
|
LGTM, And Thanks for updateing doc. |
gmarull
approved these changes
Oct 23, 2023
carlocaione
approved these changes
Oct 24, 2023
povergoing
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a GPIO driver for the BCM2711 SoC recently introduced in #62320. It also adds an LED node for the
rpi_4bboard, enabling the blinky sample to work on this board.Minor adjustments have also been made to the doc and DTS for this SoC/board to facilitate future contributions.