Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: work_queue: fix few mismatched CONTAINER_OF #62018

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

fabiobaltieri
Copy link
Member

Fix few mismatched CONTAINER_OF, going from struct k_work to struct triggered_test_item should pass by struct k_work_poll.

Fix few mismatched CONTAINER_OF, going from struct k_work to struct
triggered_test_item should pass by struct k_work_poll.

Signed-off-by: Fabio Baltieri <[email protected]>
Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. But it worked because the field was at the top of (wrong) struct?

@fabiobaltieri
Copy link
Member Author

fabiobaltieri commented Aug 29, 2023

Ouch. But it worked because the field was at the top of (wrong) struct?

Yeah, found quite few of these, I'm adding type checking in #61962, that's how I found these, will undraft that after all the fixes are in. Feel free to check 1bcd92d already if you have time, I could use some early feedback on the macro, though it's essentially copied from Linux so it should be ok.

@cfriedt cfriedt merged commit a15e7d2 into zephyrproject-rtos:main Aug 30, 2023
@fabiobaltieri fabiobaltieri deleted the co-1 branch August 30, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants