-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Bluetooth: Mesh: Use bsim settings backend #61074
Merged
carlescufi
merged 3 commits into
zephyrproject-rtos:main
from
alxelax:use_bsim_settings_backend
Aug 23, 2023
Merged
tests: Bluetooth: Mesh: Use bsim settings backend #61074
carlescufi
merged 3 commits into
zephyrproject-rtos:main
from
alxelax:use_bsim_settings_backend
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxelax
force-pushed
the
use_bsim_settings_backend
branch
from
August 2, 2023 13:27
ab5bf65
to
697c1db
Compare
alxelax
force-pushed
the
use_bsim_settings_backend
branch
from
August 21, 2023 12:05
697c1db
to
4366683
Compare
alxelax
requested review from
jhedberg,
Vudentz,
wopu-ot and
PavelVPV
as code owners
August 21, 2023 12:12
Andrewpini
previously approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 One minor comment.
alxelax
force-pushed
the
use_bsim_settings_backend
branch
from
August 21, 2023 14:25
4366683
to
3595a4b
Compare
Andrewpini
previously approved these changes
Aug 21, 2023
PavelVPV
requested changes
Aug 21, 2023
tests/bsim/bluetooth/mesh/tests_scripts/blob_mdls/blob_srv_persistence.sh
Outdated
Show resolved
Hide resolved
PSA ITS settings area does not belong to Bluetooth. It should be restored before Bluetooth persistent data. Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax
force-pushed
the
use_bsim_settings_backend
branch
from
August 22, 2023 13:36
3595a4b
to
1e84473
Compare
PavelVPV
reviewed
Aug 22, 2023
Commit adds using BabbleSim's settings backend instead of proprietary one that is based on POSIX files. Signed-off-by: Aleksandr Khromykh <[email protected]>
DFU slot sequence depends on the settings backend. Commit adapts test after changing bsim settings backend. Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax
force-pushed
the
use_bsim_settings_backend
branch
from
August 22, 2023 13:57
1e84473
to
a7482ee
Compare
PavelVPV
approved these changes
Aug 22, 2023
Andrewpini
approved these changes
Aug 23, 2023
Balaklaka
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds using nrf52_bsim platform NVMC implementation as well as flash for settings and NVS instead of proprietary custom settings backend.