Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Bluetooth: Mesh: Use bsim settings backend #61074

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

alxelax
Copy link
Collaborator

@alxelax alxelax commented Aug 2, 2023

PR adds using nrf52_bsim platform NVMC implementation as well as flash for settings and NVS instead of proprietary custom settings backend.

@alxelax alxelax force-pushed the use_bsim_settings_backend branch from ab5bf65 to 697c1db Compare August 2, 2023 13:27
@Balaklaka Balaklaka self-requested a review August 7, 2023 14:45
@alxelax alxelax force-pushed the use_bsim_settings_backend branch from 697c1db to 4366683 Compare August 21, 2023 12:05
@alxelax alxelax marked this pull request as ready for review August 21, 2023 12:12
Andrewpini
Andrewpini previously approved these changes Aug 21, 2023
Copy link
Collaborator

@Andrewpini Andrewpini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 One minor comment.

tests/bsim/bluetooth/mesh/src/test_replay_cache.c Outdated Show resolved Hide resolved
Andrewpini
Andrewpini previously approved these changes Aug 21, 2023
PSA ITS settings area does not belong to Bluetooth.
It should be restored before Bluetooth persistent data.

Signed-off-by: Aleksandr Khromykh <[email protected]>
Commit adds using BabbleSim's settings backend instead of
proprietary one that is based on POSIX files.

Signed-off-by: Aleksandr Khromykh <[email protected]>
DFU slot sequence depends on the settings backend.
Commit adapts test after changing bsim settings backend.

Signed-off-by: Aleksandr Khromykh <[email protected]>
@alxelax alxelax force-pushed the use_bsim_settings_backend branch from 1e84473 to a7482ee Compare August 22, 2023 13:57
@alxelax alxelax requested a review from PavelVPV August 22, 2023 13:58
@carlescufi carlescufi merged commit b714100 into zephyrproject-rtos:main Aug 23, 2023
@alxelax alxelax deleted the use_bsim_settings_backend branch August 23, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants