driver:flash:spi_nor: provide api to reset the flash registers #61019
Conversation
ddeshat
requested review from
nashif,
carlescufi,
galak,
MaureenHelm and
de-nordic
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ddeshat, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
ddeshat
changed the title
ddeshat
force-pushed
the
flash_api_reset_mem
branch
from
ee0cdb5 to
869dd8a
Compare
Done |
|
LGTM |
ddeshat
force-pushed
the
flash_api_reset_mem
branch
from
869dd8a to
ce4d957
Compare
There was a problem hiding this comment.
Missing z_vrfy_ definitions.
IMHO this should be implemented as ex_op rather than additional syscall, as all syscall additions grows the API for every instance of driver and this is not something that will be very often called so does not require efficiency of direct call.
ddeshat
force-pushed
the
flash_api_reset_mem
branch
2 times, most recently
from
800678c to
739f589
Compare
Done, ex_op is used to send the required commands. |
ddeshat
force-pushed
the
flash_api_reset_mem
branch
from
a9047bc to
dab07f0
Compare
ddeshat
force-pushed
the
flash_api_reset_mem
branch
from
dab07f0 to
7048e48
Compare
ddeshat
force-pushed
the
flash_api_reset_mem
branch
from
7048e48 to
7681203
Compare
ddeshat
dismissed stale reviews from keith-zephyr and fabiobaltieri
via
9757016
ddeshat
force-pushed
the
flash_api_reset_mem
branch
from
7681203 to
9757016
Compare
changes enable flash driver to provide api interface to send reset memory spi command to the spi flash. The reset memory command would bring the spi flash to its default power-on state and loose all the volatile register settings. Flash reset is needed when more than one controller access the flash chip in a shared mode. Signed-off-by: Deepti Deshatty <[email protected]>
ddeshat
force-pushed
the
flash_api_reset_mem
branch
from
9757016 to
6d0c9e0
Compare
|
Hi @de-nordic , can you pls help close this comment? I dont see an option to close this comment and this is blocking merge. |
|
Hi @ddeshat! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
changes enables flash driver to provides api interface to send reset memory spi command to the spi flash. The reset memory command would bring the SPI flash to its default power-on state and loose all the volatile register settings.
Flash reset is needed when more than one masters accessing the flash chip in a shared mode.