fs: Remove NFFS support #21793
Merged
fs: Remove NFFS support #21793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: native port
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
nvlsianpu
force-pushed
the
remove-nffs
branch
4 times, most recently
from
9c26e61
to
743441c
Compare
nvlsianpu
force-pushed
the
remove-nffs
branch
from
743441c
to
a00a369
Compare
nvlsianpu
force-pushed
the
remove-nffs
branch
3 times, most recently
from
b57f40d
to
7d987c0
Compare
settings nffs targeted test were removed. the file function settings suite was disabled as need some rework in order to use litlefs. Signed-off-by: Andrzej Puzdrowski <[email protected]>
Switch to using LittleFS instead of NFFS, which will be removed. Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
remove-nffs
branch
2 times, most recently
from
42823a6
to
74c171f
Compare
nvlsianpu
requested review from
andrewboie,
carlescufi,
galak,
ioannisg,
jakub-uC,
lemrey,
MaureenHelm and
nashif
as code owners
carlescufi
approved these changes
Jan 16, 2020
nashif
approved these changes
Jan 16, 2020
andrewboie
approved these changes
Jan 16, 2020
lemrey
reviewed
Jan 17, 2020
lemrey
reviewed
Jan 17, 2020
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| storage_partition: partition@70000 { | |||
| label = "storage"; | |||
| reg = <0x00070000 0x10000>; | |||
There was a problem hiding this comment.
Without it the storage is too small to run the testsuite.
This patch addapt the sample to using LittleFS as the FS back-end. After NFFS will be removed this ensures mcumgr FS command functionality. Signed-off-by: Andrzej Puzdrowski <[email protected]> smp_svr cleanu
NFFS configuration was removed. Added working configuration for nRF boards. Documentation aligned to fact that littlefs is supported. Signed-off-by: Andrzej Puzdrowski <[email protected]>
Switch to using LittleFS instead of NFFS, which was removed. Signed-off-by: Andrzej Puzdrowski <[email protected]>
As multi-fs testsuite uses FS and NFFS it must be disabled as NFFS was removed. Further thin test should be reworked to use litlefs in place of NFFS. Signed-off-by: Andrzej Puzdrowski <[email protected]>
NFFS was removed, so it tests need to be removed too. Signed-off-by: Andrzej Puzdrowski <[email protected]>
NFFS is removed as it has serious bugs (by design) which haven't been resolved since extended range of time. One of most serious issues bunch were described here: apache/mynewt-nffs#10 Since lack of support NFFS upsterem it doesn't make sense to keep it in zephyr. Signed-off-by: Andrzej Puzdrowski <[email protected]>
NFFS support repository reference was removed as unneeded anymore by removal of NFFS support in the codebase. Signed-off-by: Andrzej Puzdrowski <[email protected]>
Replaced NFFS mentions by LittleFS in all <board>.dts comments to storage partitions. Replaced NFFS by LittleFS in a few boards documentation. Signed-off-by: Andrzej Puzdrowski <[email protected]>
Patch introduce references to LittleFS instead of NFFS where it was suitable. In other places NFFS mentions were removed Signed-off-by: Andrzej Puzdrowski <[email protected]>
This patch is for suppress CI Kconfig issues caused by temporary dead code in this test-suie. Signed-off-by: Andrzej Puzdrowski <[email protected]>
Add removal record to the incoming release note. Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
remove-nffs
branch
from
74c171f
to
0bcddbc
Compare
nvlsianpu
commented
Jan 17, 2020
There was a problem hiding this comment.
Inconsistent naming of LittleFS within documentation; varies from littlefs to Littlefs to LittleFS
use LittleFS in whole patch
@carlescufi
Typos were fixed
Something seems off with tests/subsys/fs/multi-fs, could you please double check that you have removed the nffs-related files there? Plus, which other FS will we be testing in that test, now that nffs was removed?
@lemrey
Don't wary about this testsuite: It will be LittleFS - see #21973
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| storage_partition: partition@70000 { | |||
| label = "storage"; | |||
| reg = <0x00070000 0x10000>; | |||
There was a problem hiding this comment.
Without it the storage is too small to run the testsuite.
lemrey
approved these changes
Jan 17, 2020
ioannisg
approved these changes
Jan 17, 2020
de-nordic
approved these changes
Jan 21, 2020
This was referenced Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFFS haven't been supported in its upstream since more than a year.
It has serous issues which causes it highly unreliable (see; apache/mynewt-nffs#10 and others).
As Litlefs support is available in the zephyr since while it doesn't make any sense to keep NFFS support as it losted even education value: LitleFS is better substitute.
NFFS is removed "immediately" as zephyr API deprecation process guide stands:
following projects were switched from NFFS to LittleFS
Configuration of samples/subsys/shell/fs sample was truncated by NFFS related records.
tests/subsys/fs/multi-fs test-case was disabled. It will be reworked and restored to CI in another PR: #21973