drivers/spi/spi_gecko_eusart.c:180 trailing whitespace

Process completed with exit code 5.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. TRAILING_WHITESPACE: trailing whitespace File:drivers/spi/spi_gecko_eusart.c Line:180

Check YAML files with YAMLLint. YAMLLint (new-line-at-end-of-file):no new line character at the end of file File:dts/bindings/spi/silabs,gecko-spi-eusart.yaml Line:21 Column:19

Git conflict markers and whitespace errors are not allowed in added changes c161eee68eceb3e3d2df7385d9336cb46a20f365: drivers/spi/spi_gecko_eusart.c:180: trailing whitespace.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. Missing newline at end of 'dts/bindings/spi/silabs,gecko-spi-eusart.yaml'. Check your text editor settings.

Process completed with exit code 1.

dts/bindings/spi/silabs,gecko-spi-eusart.yaml:21 no new line character at the end of file

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define GET_GECKO_EUSART_CLOCK(idx) \ - .clock_dev = DEVICE_DT_GET(DT_INST_CLOCKS_CTLR(idx)), \ +#define GET_GECKO_EUSART_CLOCK(idx) \ + .clock_dev = DEVICE_DT_GET(DT_INST_CLOCKS_CTLR(idx)), \ .clock_cfg = SILABS_DT_INST_CLOCK_CFG(idx), #else #if (EUSART_COUNT == 1) -#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 \ - : -1) +#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 : -1) #elif (EUSART_COUNT == 2) -#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 \ - : ((ref) == EUSART1) ? cmuClock_EUSART1 \ - : -1) +#define CLOCK_EUSART(ref) \ + (((ref) == EUSART0) ? cmuClock_EUSART0 : ((ref) == EUSART1) ? cmuClock_EUSART1 : -1) #elif (EUSART_COUNT == 3) -#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 \ - : ((ref) == EUSART1) ? cmuClock_EUSART1 \ - : ((ref) == EUSART2) ? cmuClock_EUSART2 \ - : -1) +#define CLOCK_EUSART(ref) \ + (((ref) == EUSART0) ? cmuClock_EUSART0 \ + : ((ref) == EUSART1) ? cmuClock_EUSART1 \ + : ((ref) == EUSART2) ? cmuClock_EUSART2 \ + : -1) #elif (EUSART_COUNT == 4) -#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 \ - : ((ref) == EUSART1) ? cmuClock_EUSART1 \ - : ((ref) == EUSART2) ? cmuClock_EUSART2 \ - : ((ref) == EUSART3) ? cmuClock_EUSART3 \ - : -1) +#define CLOCK_EUSART(ref) \ + (((ref) == EUSART0) ? cmuClock_EUSART0 \ + : ((ref) == EUSART1) ? cmuClock_EUSART1 \ + : ((ref) == EUSART2) ? cmuClock_EUSART2 \ + : ((ref) == EUSART3) ? cmuClock_EUSART3 \ + : -1) #else #error "Undefined number of USARTs." #endif /* USART_COUNT */ -#define GET_GECKO_EUSART_CLOCK(id) \ - .clock = CLOCK_EUSART((EUSART_TypeDef *)DT_INST_REG_ADDR(id)), +#define GET_GECKO_EUSART_CLOCK(id) .clock = CLOCK_EUSART((EUSART_TypeDef *)DT_INST_REG_ADDR(id)), File:drivers/spi/spi_gecko_eusart.c Line:56 You may want to run clang-format on this change: - #ifdef CONFIG_CLOCK_CONTROL +#ifdef CONFIG_CLOCK_CONTROL File:drivers/spi/spi_gecko_eusart.c Line:89 You may want to run clang-format on this change: - err = clock_control_on(gecko_config->clock_dev, - (clock_control_subsys_t)&gecko_config->clock_cfg); + err = clock_control_on(gecko_config->clock_dev, + (clock_control_subsys_t)&gecko_config->clock_cfg); File:drivers/spi/spi_gecko_eusart.c Line:182 You may want to run clang-format on this change: -#define SPI_INIT(n) \ - PINCTRL_DT_INST_DEFINE(n); \ - static struct spi_gecko_eusart_data spi_gecko_eusart_data_##n = { \ - SPI_CONTEXT_INIT_LOCK(spi_gecko_eusart_data_##n, ctx), \ - SPI_CONTEXT_INIT_SYNC(spi_gecko_eusart_data_##n, ctx), \ - SPI_CONTEXT_CS_GPIOS_INITIALIZE(DT_DRV_INST(n), ctx)}; \ - static struct spi_gecko_eusart_config spi_gecko_eusart_cfg_##n = { \ - .pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(n), \ - .base = (EUSART_TypeDef *)DT_INST_REG_ADDR(n), \ - GET_GECKO_EUSART_CLOCK(n) \ - .clock_frequency = DT_INST_PROP_OR(n, clock_frequency, 1000000) \ - }; \ - DEVICE_DT_INST_DEFINE(n, spi_gecko_eusart_init, NULL, &spi_gecko_eusart_data_##n, \ - &spi_gecko_eusart_cfg_##n, POST_KERNEL, CONFIG_SPI_INIT_PRIORITY, \ +#define SPI_INIT(n)

drivers/spi/spi_gecko_eusart.c:56 -#define GET_GECKO_EUSART_CLOCK(idx) \ - .clock_dev = DEVICE_DT_GET(DT_INST_CLOCKS_CTLR(idx)), \ +#define GET_GECKO_EUSART_CLOCK(idx) \ + .clock_dev = DEVICE_DT_GET(DT_INST_CLOCKS_CTLR(idx)), \ .clock_cfg = SILABS_DT_INST_CLOCK_CFG(idx), #else #if (EUSART_COUNT == 1) -#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 \ - : -1) +#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 : -1) #elif (EUSART_COUNT == 2) -#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 \ - : ((ref) == EUSART1) ? cmuClock_EUSART1 \ - : -1) +#define CLOCK_EUSART(ref) \ + (((ref) == EUSART0) ? cmuClock_EUSART0 : ((ref) == EUSART1) ? cmuClock_EUSART1 : -1) #elif (EUSART_COUNT == 3) -#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 \ - : ((ref) == EUSART1) ? cmuClock_EUSART1 \ - : ((ref) == EUSART2) ? cmuClock_EUSART2 \ - : -1) +#define CLOCK_EUSART(ref) \ + (((ref) == EUSART0) ? cmuClock_EUSART0 \ + : ((ref) == EUSART1) ? cmuClock_EUSART1 \ + : ((ref) == EUSART2) ? cmuClock_EUSART2 \ + : -1) #elif (EUSART_COUNT == 4) -#define CLOCK_EUSART(ref) (((ref) == EUSART0) ? cmuClock_EUSART0 \ - : ((ref) == EUSART1) ? cmuClock_EUSART1 \ - : ((ref) == EUSART2) ? cmuClock_EUSART2 \ - : ((ref) == EUSART3) ? cmuClock_EUSART3 \ - : -1) +#define CLOCK_EUSART(ref) \ + (((ref) == EUSART0) ? cmuClock_EUSART0 \ + : ((ref) == EUSART1) ? cmuClock_EUSART1 \ + : ((ref) == EUSART2) ? cmuClock_EUSART2 \ + : ((ref) == EUSART3) ? cmuClock_EUSART3 \ + : -1) #else #error "Undefined number of USARTs." #endif /* USART_COUNT */ -#define GET_GECKO_EUSART_CLOCK(id) \ - .clock = CLOCK_EUSART((EUSART_TypeDef *)DT_INST_REG_ADDR(id)), +#define GET_GECKO_EUSART_CLOCK(id) .clock = CLOCK_EUSART((EUSART_TypeDef *)DT_INST_REG_ADDR(id)),

drivers/spi/spi_gecko_eusart.c:89 - #ifdef CONFIG_CLOCK_CONTROL +#ifdef CONFIG_CLOCK_CONTROL

drivers/spi/spi_gecko_eusart.c:182 - err = clock_control_on(gecko_config->clock_dev, - (clock_control_subsys_t)&gecko_config->clock_cfg); + err = clock_control_on(gecko_config->clock_dev, + (clock_control_subsys_t)&gecko_config->clock_cfg);

drivers/spi/spi_gecko_eusart.c:360 -#define SPI_INIT(n) \ - PINCTRL_DT_INST_DEFINE(n); \ - static struct spi_gecko_eusart_data spi_gecko_eusart_data_##n = { \ - SPI_CONTEXT_INIT_LOCK(spi_gecko_eusart_data_##n, ctx), \ - SPI_CONTEXT_INIT_SYNC(spi_gecko_eusart_data_##n, ctx), \ - SPI_CONTEXT_CS_GPIOS_INITIALIZE(DT_DRV_INST(n), ctx)}; \ - static struct spi_gecko_eusart_config spi_gecko_eusart_cfg_##n = { \ - .pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(n), \ - .base = (EUSART_TypeDef *)DT_INST_REG_ADDR(n), \ - GET_GECKO_EUSART_CLOCK(n) \ - .clock_frequency = DT_INST_PROP_OR(n, clock_frequency, 1000000) \ - }; \ - DEVICE_DT_INST_DEFINE(n, spi_gecko_eusart_init, NULL, &spi_gecko_eusart_data_##n, \ - &spi_gecko_eusart_cfg_##n, POST_KERNEL, CONFIG_SPI_INIT_PRIORITY, \ +#define SPI_INIT(n) \ + PINCTRL_DT_INST_DEFINE(n); \ + static struct spi_gecko_eusart_data spi_gecko_eusart_data_##n = { \ + SPI_CONTEXT_INIT_LOCK(spi_gecko_eusart_data_##n, ctx), \ + SPI_CONTEXT_INIT_SYNC(spi_gecko_eusart_data_##n, ctx), \ + SPI_CONTEXT_CS_GPIOS_INITIALIZE(DT_DRV_INST(n), ctx)}; \ + static struct spi_gecko_eusart_config spi_gecko_eusart_cfg_##n = { \ + .pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(n), \ + .base = (EUSART_TypeDef *)DT_INST_REG_ADDR(n), \ + GET_GECKO_EUSART_CLOCK(n).clock_frequency = \ + DT_INST_PROP_OR(n, clock_frequency, 1000000)}; \ + DEVICE_DT_INST_DEFINE(n, spi_gecko_eusart_init, NULL, &spi_gecko_eusart_data_##n, \ + &spi_gecko_eusart_cfg_##n, POST_KERNEL, CONFIG_SPI_INIT_PRIORITY, \

drivers/spi/spi_gecko_usart.c:84 -#define GET_GECKO_USART_CLOCK(idx) \ - .clock_dev = DEVICE_DT_GET(DT_INST_CLOCKS_CTLR(idx)), \ +#define GET_GECKO_USART_CLOCK(idx) \ + .clock_dev = DEVICE_DT_GET(DT_INST_CLOCKS_CTLR(idx)), \ .clock_cfg = SILABS_DT_INST_CLOCK_CFG(idx), #elif DT_NODE_HAS_PROP(n, peripheral_id) -#define CLOCK_USART(id) _CONCAT(cmuClock_USART, id) -#define GET_GECKO_USART_CLOCK(n) \ - .clock = CLOCK_USART(DT_INST_PROP(n, peripheral_id)), +#define CLOCK_USART(id) _CONCAT(cmuClock_USART, id) +#define GET_GECKO_USART_CLOCK(n) .clock = CLOCK_USART(DT_INST_PROP(n, peripheral_id)), #else #if (USART_COUNT == 1) -#define CLOCK_USART(ref) (((ref) == USART0) ? cmuClock_USART0 \ - : -1) +#define CLOCK_USART(ref) (((ref) == USART0) ? cmuClock_USART0 : -1) #elif (USART_COUNT == 2) -#define CLOCK_USART(ref) (((ref) == USART0) ? cmuClock_USART0 \ - : ((ref) == USART1) ? cmuClock_USART1 \ - : -1) +#define CLOCK_USART(ref) \ + (((ref) == USART0) ? cmuClock_USART0 : ((ref) == USART1) ? cmuClock_USART1 : -1) #elif (USART_COUNT == 3) -#define CLOCK_USART(ref) (((ref) == USART0) ? cmuClock_USART0 \ - : ((ref) == USART1) ? cmuClock_USART1 \ - : ((ref) == USART2) ? cmuClock_USART2 \ - : -1) +#define CLOCK_USART(ref) \ + (((ref) == USART0) ? cmuClock_USART0 \ + : ((ref) == USART1) ? cmuClock_USART1 \ + : ((ref) == USART2) ? cmuClock_USART2 \ + : -1) #elif (USART_COUNT == 4) -#define CLOCK_USART(ref) (((ref) == USART0) ? cmuClock_USART0 \ - : ((ref) == USART1) ? cmuClock_USART1 \ - : ((ref) == USART2) ? cmuClock_USART2 \ - : ((ref) == USART3) ? cmuClock_USART3 \ - : -1) +#define CLOCK_USART(ref) \ + (((ref) == USART0) ? cmuClock_USART0 \ + : ((ref) == USART1) ? cmuClock_USART1 \ + : ((ref) == USART2) ? cmuClock_USART2 \ + : ((ref) == USART3) ? cmuClock_USART3 \ + : -1) #elif (USART_COUNT == 5) -#define CLOCK_USART(ref) (((ref) == USART0) ? cmuClock_USART0 \ - : ((ref) == USART1) ? cmuClock_USART1 \ - : ((ref) == USART2) ? cmuClock_USART2 \ - : ((ref) == USART3) ? cmuClock_USART3 \ - : ((ref) == USART4) ? cmuClock_USART4 \ - : -1) +#define CLOCK_USART(ref) \ + (((ref) == USART0) ? cmuClock_USART0 \ + : ((ref) == USART1) ? cmuClock_USART1 \ + : ((ref) == USART2) ? cmuClock_USART2 \ + : ((ref) == USART3) ? cmuClock_USART3 \ + : ((ref) == USART4) ? cmuClock_USART4 \ + : -1) #elif (USART_COUNT == 6) -#define CLOCK_USART(ref) (((ref) == USART0) ? cmuClock_USART0 \ - : ((ref) == USART1) ? cmuClock_USART1 \ - : ((ref) == USART2) ? cmuClock_USART2 \ - : ((ref) == USART3) ? cmuClock_USART3 \ - : ((ref) == USART4) ? cmuClock_USART4 \ - : ((ref) == USART5) ? cmuClock_USART5 \ - : -1) +#define CLOCK_USART(ref) \ + (((ref) == USART0) ? cmuClock_USART0

drivers/spi/spi_gecko_usart.c:119 - /* Helper Functions */ -static int spi_config(const struct device *dev, - const struct spi_config *config, - uint16_t *control) +static int spi_config(const struct device *dev, const struct spi_config *config, uint16_t *control)

drivers/spi/spi_gecko_usart.c:214 - gecko_config->base->FRAME = usartDatabits8 - | USART_FRAME_STOPBITS_DEFAULT - | USART_FRAME_PARITY_DEFAULT; + gecko_config->base->FRAME = + usartDatabits8 | USART_FRAME_STOPBITS_DEFAULT | USART_FRAME_PARITY_DEFAULT;

drivers/spi/spi_gecko_usart.c:255 -static int spi_gecko_shift_frames(USART_TypeDef *usart, - struct spi_gecko_data *data) +static int spi_gecko_shift_frames(USART_TypeDef *usart, struct spi_gecko_data *data)

drivers/spi/spi_gecko_usart.c:275 - -static void spi_gecko_xfer(const struct device *dev, - const struct spi_config *config) +static void spi_gecko_xfer(const struct device *dev, const struct spi_config *config)