Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LVGL: Add check for LVGL symbol to Kconfig #48

Merged
merged 1 commit into from
Nov 2, 2023
Merged

LVGL: Add check for LVGL symbol to Kconfig #48

merged 1 commit into from
Nov 2, 2023

Conversation

faxe1008
Copy link
Contributor

@faxe1008 faxe1008 commented Nov 2, 2023

Description of the feature or fix

LVGL kconfig symbols ended up in generated headers although LVGL was never enabled.

cc: @nashif

@fabiobaltieri
Copy link
Member

This includes a bunch of other commits, is that intentional? Worth mentioning it in the PR description.

@faxe1008
Copy link
Contributor Author

faxe1008 commented Nov 2, 2023

This includes a bunch of other commits, is that intentional? Worth mentioning it in the PR description.

Did not notice I had the 8.3.10 branch which I use for regression testing checked out. You were quick to catch it :D.

@fabiobaltieri
Copy link
Member

no prob, do you have a west PR pointing to the draft of this as well? Not much that can go wrong but you need it to integrate anyway...

@faxe1008 faxe1008 mentioned this pull request Nov 2, 2023
Closed
17 tasks
@faxe1008
Copy link
Contributor Author

faxe1008 commented Nov 2, 2023 •
edited
Loading

no prob, do you have a west PR pointing to the draft of this as well? Not much that can go wrong but you need it to integrate anyway...

Nope not yet, I did some testing locally first with the current state. At least for me the opacity regression introduced from 8.3.9 was an issue so I am currently waiting for a release 8.3.11 and updating the PR with that. I wanted to wait with the west PR until I could not find any showstoppers. :^)

For this current PR I will create one.

faxe1008 added a commit to faxe1008/zephyr that referenced this pull request Nov 2, 2023
@faxe1008
manifest: update LVGL to add Kconfig guard
2708396 
Related to zephyrproject-rtos/lvgl#48

Signed-off-by: Fabian Blatz <[email protected]>
@faxe1008 faxe1008 mentioned this pull request Nov 2, 2023
Merged
kartben
kartben reviewed Nov 2, 2023
View reviewed changes
Kconfig Show resolved Hide resolved
@fabiobaltieri
Copy link
Member

Uh, zephyrproject-rtos/zephyr#64747 is very unhappy

Not much that can go wrong

haha

fabiobaltieri
fabiobaltieri reviewed Nov 2, 2023
View reviewed changes
Kconfig Outdated Show resolved Hide resolved
fabiobaltieri
fabiobaltieri reviewed Nov 2, 2023
View reviewed changes
Kconfig Outdated Show resolved Hide resolved
@faxe1008
zephyr: Kconfig: Add guard checking for LVGL module
7ab891d 
Adds a guard to the Kconfig file to prevent generation of LV_* symbols
if the module is not used.

Signed-off-by: Fabian Blatz <[email protected]>
@fabiobaltieri
Copy link
Member

Thanks!

@fabiobaltieri
Copy link
Member

zephyrproject-rtos/zephyr#64747 looks good, merging

@fabiobaltieri fabiobaltieri merged commit 7c61a4c into zephyrproject-rtos:zephyr Nov 2, 2023
6 checks passed
faxe1008 added a commit to faxe1008/zephyr that referenced this pull request Nov 6, 2023
@faxe1008
manifest: update LVGL to add Kconfig guard
7449c0f 
Related to zephyrproject-rtos/lvgl#48

Signed-off-by: Fabian Blatz <[email protected]>
carlescufi pushed a commit to zephyrproject-rtos/zephyr that referenced this pull request Nov 15, 2023
@faxe1008 @carlescufi
manifest: update LVGL to add Kconfig guard
92560ac 
Related to zephyrproject-rtos/lvgl#48

Signed-off-by: Fabian Blatz <[email protected]>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Nov 16, 2023
@faxe1008
manifest: update LVGL to add Kconfig guard
3eb8f26 
Related to zephyrproject-rtos/lvgl#48

(cherry picked from commit 92560ac)

Original-Signed-off-by: Fabian Blatz <[email protected]>
GitOrigin-RevId: 92560ac
Change-Id: I5e544616fe4c79a445bf1d7b7fb321a26217cbdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5036512
Reviewed-by: Keith Short <[email protected]>
Commit-Queue: Keith Short <[email protected]>
Tested-by: ChromeOS Prod (Robot) <[email protected]>
Tested-by: Keith Short <[email protected]>
yunheQin pushed a commit to yunheQin/zephyr that referenced this pull request Dec 6, 2023
@faxe1008 @yunheQin
manifest: update LVGL to add Kconfig guard
3633041 
Related to zephyrproject-rtos/lvgl#48

Signed-off-by: Fabian Blatz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nashif nashif nashif approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@kartben kartben kartben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faxe1008 @fabiobaltieri @kartben @nashif