bleutooth: add ble tx power configuration #355
+92
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
force-pushed
the
bt/add_tx_power
branch
from
d1efcb4
to
e779f5f
Compare
wmrsouza
approved these changes
Nov 1, 2024
raffarost
reviewed
Nov 1, 2024
zephyr/esp32/src/bt/esp_bt_adapter.c
Outdated
| else if (tx_power >= 6) return ESP_PWR_LVL_P6; | ||
| else if (tx_power >= 3) return ESP_PWR_LVL_P3; | ||
| else if (tx_power >= 0) return ESP_PWR_LVL_N0; | ||
| else if (tx_power >= -3) return ESP_PWR_LVL_N3; |
There was a problem hiding this comment.
not sure it is intended but for 2 it maps ESP_PWR_LVL_N0, but -2 it maps ESP_PWR_LVL_N3, so for negative values it rounds to the more negative (asymmetric?)
There was a problem hiding this comment.
-1 maps to ESP_PWR_LVL_N3 (-1 > -3) instead of ESP_PWR_LVL_N0, which is closer
sylvioalves
force-pushed
the
bt/add_tx_power
branch
2 times, most recently
from
837fe77
to
f799d1d
Compare
|
commit and PR name (nit) -> bleutooth |
Allow bluetooth controller to be initialized with default custom tx power level. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
bt/add_tx_power
branch
from
f799d1d
to
69bc894
Compare
marekmatej
reviewed
Nov 4, 2024
| @@ -1398,3 +1402,19 @@ static void esp_bt_free(void *mem) | |||
| { | |||
| esp_bt_free_func(mem); | |||
| } | |||
|
|
|||
| esp_power_level_t zephyr_to_esp_ble_power_level(int tx_power) { | |||
There was a problem hiding this comment.
can we use a code style with opening parentheses on the new line?
marekmatej
reviewed
Nov 4, 2024
| } | ||
|
|
||
| esp_power_level_t zephyr_to_esp_ble_power_level(int tx_power) { |
There was a problem hiding this comment.
same here and in other esp_bt_adapter.c
There was a problem hiding this comment.
I will change this approach and ping you back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow bluetooth controller to be initialized with
default custom tx power level.