Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash Message Support #11

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Flash Message Support #11

wants to merge 7 commits into from

Conversation

rgarbin
Copy link
Contributor

@rgarbin rgarbin commented Aug 13, 2017

Added test to send msg (simple / multiple) using flash msg.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 73.75% when pulling 4c02cc0 on flash_msg into 60d6436 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-31.8%) to 40.741% when pulling 466aa9d on flash_msg into 60d6436 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-20.6%) to 51.852% when pulling 1f05faa on flash_msg into 60d6436 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-12.006%) to 60.494% when pulling 5683a41 on flash_msg into 60d6436 on master.

@anderkonzen
Copy link

LGTM!

Copy link

@anderkonzen anderkonzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the drop in coverage, but it looks good to me!

@jonatasfreitasv
Copy link
Contributor

jonatasfreitasv commented Jun 20, 2018

@rgarbin and @anderkonzen
Hi guys!

This PR is still valid

If yes, plz solve conflicts for merge.

Thx a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants