Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openaire: added delete and restore components #548

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

alejandromumo
Copy link
Member

closes #544

@alejandromumo alejandromumo force-pushed the add_openaire_delete_restore branch from d4fc85c to a7dd622 Compare September 26, 2023 12:55
)
]

mocked_session.post.assert_has_calls(post_calls)
Copy link
Contributor

@kpsherva kpsherva Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker: does it make sense to check the returns and arguments too ?

Copy link
Member Author

@alejandromumo alejandromumo Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns are completely mocked since we're not hitting any real API.

Arguments are already being checked since we're passing specific call objects: docs

@zzacharo zzacharo merged commit 1275cb5 into zenodo:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAIRE: enable delete / restore
3 participants