global: enabled sort by verified #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandromumo
force-pushed
the
enable_sort_by_verified
branch
from
594d360 to
cccf47c
Compare
alejandromumo
commented
Sep 25, 2023
site/zenodo_rdm/redirector.py
Outdated
| @@ -54,7 +54,9 @@ def communities_detail_view_function(): | |||
| :return: url for the view 'invenio_app_rdm_communities.communities_detail' | |||
| :rtype: str | |||
| """ | |||
| _id = request.view_args.get("id", request.view_args["community_id"]) | |||
| _id = request.view_args.get("id") | |||
There was a problem hiding this comment.
the default value was analysed when it wasn't needed. This was throwing an exception when community_id was not in view_args
There was a problem hiding this comment.
do we know in which cases we end up with missing community_id while the code expected it? Does it make sense to identify why it happens?
There was a problem hiding this comment.
Indeed, by having a closer look I found out that community_id was never a view argument for any of the redirected routes (the pydoc was misleading).
The redirected routes that hit this view are the following:
"redirect_communities_about_legacy": {
"source": "/communities/about/<id>/",
"target": communities_detail_view_function,
},
"redirect_collections_about": {
"source": "/collection/user-<id>",
"target": communities_detail_view_function,
},which means that id is the only view argument.
I also updated the pydoc of the method for clarity
alejandromumo
force-pushed
the
enable_sort_by_verified
branch
from
2f9526b to
efbb27e
Compare
kpsherva
reviewed
Sep 26, 2023
alejandromumo
force-pushed
the
enable_sort_by_verified
branch
from
2cbd457 to
a7a5b18
Compare
alejandromumo
force-pushed
the
enable_sort_by_verified
branch
from
a7a5b18 to
7c0277b
Compare
kpsherva
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.