-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sitemap: move sitemap module from legacy #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work overall and with the queries for getting the models 👍
Some nits and naming, but otherwise looks good.
{%- if url.changefreq %} | ||
<changefreq>{{ url.changefreq }}</changefreq> | ||
{%- endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can't reliably calculate this, since records/communities could change by users at any moment/frequency.
b46fa79
to
c5bf8ff
Compare
* sitemaps: add sitemaps module from legacy with updated license * sitemaps: use CommunityMetadata instead of Community * sitemap: add celery task in config and fix imports * sitemap: generators: use correct views for community routes * sitemap: generators: use correct models/views for record routes * Add *.xml files to MANIFEST
Description
Move sitemap module from Legacy Zenodo to ZenodoRDM
The models and views are changed as applicable in RDM, at the time of creation of this PR, there are no new additions to the sitemap entries.
Closes https://github.com/zenodo/rdm-project/issues/43
Checklist
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: