Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sitemap: move sitemap module from legacy #505

Merged
merged 10 commits into from
Sep 18, 2023

Conversation

yashlamba
Copy link
Member

@yashlamba yashlamba commented Sep 15, 2023

Description

Move sitemap module from Legacy Zenodo to ZenodoRDM

The models and views are changed as applicable in RDM, at the time of creation of this PR, there are no new additions to the sitemap entries.

Closes https://github.com/zenodo/rdm-project/issues/43

Checklist

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@yashlamba yashlamba requested a review from slint September 15, 2023 11:59
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work overall and with the queries for getting the models 👍

Some nits and naming, but otherwise looks good.

invenio.cfg Outdated Show resolved Hide resolved
site/zenodo_rdm/sitemap/config.py Outdated Show resolved Hide resolved
site/zenodo_rdm/sitemap/tasks.py Outdated Show resolved Hide resolved
site/zenodo_rdm/sitemap/generators.py Outdated Show resolved Hide resolved
Comment on lines +9 to +11
{%- if url.changefreq %}
<changefreq>{{ url.changefreq }}</changefreq>
{%- endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can't reliably calculate this, since records/communities could change by users at any moment/frequency.

site/zenodo_rdm/sitemap/tasks.py Outdated Show resolved Hide resolved
@slint slint merged commit 94d809a into zenodo:master Sep 18, 2023
alejandromumo pushed a commit to alejandromumo/zenodo-rdm that referenced this pull request Jul 16, 2024
* sitemaps: add sitemaps module from legacy with updated license
* sitemaps: use CommunityMetadata instead of Community
* sitemap: add celery task in config and fix imports
* sitemap: generators: use correct views for community routes
* sitemap: generators: use correct models/views for record routes
* Add *.xml files to MANIFEST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants