subcommunities: add invitation request #1067
Conversation
carlinmack
force-pushed
the
subcom-invitation
branch
2 times, most recently
from
193ddc6 to
22eea5a
Compare
| return current_community_records_service.search( | ||
| system_identity, community_id=community_id | ||
| ) |
There was a problem hiding this comment.
major/shelve: this method only returns the first 25 results from the record search, so the code below doesn't "bulk add" all the records of the community.
This actually is a bug even in our subcommunity inclusion request logic above, which means that when we accept subcommunity requests, this doesn't add ALL the records of the community to the parent community.
It's relatively low impact though, since most communities don't have that many records (or probably have no records at all, since they've just being created). For the new request type though, this will not be the case, so this has to be fixed relatively quick.
carlinmack
force-pushed
the
subcom-invitation
branch
from
e999a57 to
bae253f
Compare
slint
force-pushed
the
subcom-invitation
branch
from
aae2bc1 to
57f76f8
Compare
move submit_join_as_subcommunity_request to communities services
slint
force-pushed
the
subcom-invitation
branch
from
57f76f8 to
e4d52df
Compare
slint
force-pushed
the
subcom-invitation
branch
from
e4d52df to
1ad7bf1
Compare
* The v2.1.2 release has been yanked because of some issues with the sentry_sdk extra.
There was a problem hiding this comment.
Oh no, my infamous sleep.py script for deployment shenanigans 😱
Close #1061