Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix HTML title #119

Merged
merged 1 commit into from
Mar 19, 2024
Merged

bug: fix HTML title #119

merged 1 commit into from
Mar 19, 2024

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Mar 19, 2024

Close https://github.com/zenodo/ops/issues/390

Change:

<title>{% if title %}{% block title %}{% endblock %} | {% endif %}Zenodo</title>

to

<title>{% block title %}{% endblock %}{% if self.title() %} | {% endif %}Zenodo</title>

The error is that the person who wrote this confused title for a variable when it is a block. Ref https://stackoverflow.com/questions/18720899/how-can-i-determine-if-a-jinja2-template-block-is-empty

@lnielsen lnielsen merged commit 8a1abab into zenodo:master Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants