-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump langchain
, disable llama_index
, and fix Vector Store materializer
#2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
added
bug
Something isn't working
internal
To filter out internal PRs and issues
dependencies
Pull requests that update a dependency file
breaking-change
labels
Nov 2, 2023
htahir1
approved these changes
Nov 2, 2023
avishniakov
approved these changes
Nov 2, 2023
strickvl
changed the title
Bump
Bump Nov 2, 2023
langchain
and fix Vector Store materializerlangchain
and llama_index
, and fix Vector Store materializer
strickvl
changed the title
Bump
Bump Nov 3, 2023
langchain
and llama_index
, and fix Vector Store materializerlangchain
, disable llama_index
, and fix Vector Store materializer
@avishniakov am merging this because it's just the MCP test that's failing. Let's fix that in a separate PR off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
bug
Something isn't working
dependencies
Pull requests that update a dependency file
internal
To filter out internal PRs and issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2012 by:
langchain
dependency to>=0.0.325
(which handles the critical severity vulnerabilityllama_index
integration untilsqlmodel
allowssqlalchemy>=2.0
(see 🚀 Roadmap fastapi/sqlmodel#654 for their roadmap)Given the new base langchain dependency version, I tagged this as a breaking change, but not sure whether we consider this a breaking change per our semantic versioning.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes