Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump langchain, disable llama_index, and fix Vector Store materializer #2013

Merged
merged 21 commits into from
Nov 5, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Nov 2, 2023

Addresses #2012 by:

  • bumping our langchain dependency to >=0.0.325 (which handles the critical severity vulnerability
  • disable llama_index integration until sqlmodel allows sqlalchemy>=2.0 (see 🚀 Roadmap fastapi/sqlmodel#654 for their roadmap)
  • fixing the import for the vector store materializer
  • add (missing) test for vector store materializer
  • (fix broken test for openAI embedding materializer)

Given the new base langchain dependency version, I tagged this as a breaking change, but not sure whether we consider this a breaking change per our semantic versioning.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added bug Something isn't working internal To filter out internal PRs and issues dependencies Pull requests that update a dependency file breaking-change labels Nov 2, 2023
@strickvl strickvl changed the title Bump langchain and fix Vector Store materializer Bump langchain and llama_index, and fix Vector Store materializer Nov 2, 2023
@strickvl strickvl changed the title Bump langchain and llama_index, and fix Vector Store materializer Bump langchain, disable llama_index, and fix Vector Store materializer Nov 3, 2023
@strickvl
Copy link
Contributor Author

strickvl commented Nov 5, 2023

@avishniakov am merging this because it's just the MCP test that's failing. Let's fix that in a separate PR off develop.

@strickvl strickvl merged commit 0116355 into develop Nov 5, 2023
29 of 30 checks passed
@strickvl strickvl deleted the bugfix/OSS-2588-langchain-materializer branch November 5, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bug Something isn't working dependencies Pull requests that update a dependency file internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants