Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Ajout du CONTRIBUTING.md #269

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

loic5
Copy link
Contributor

@loic5 loic5 commented Oct 6, 2020

Fixes issue #211

Copy link

@zigarn zigarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@hgwood
Copy link
Contributor

hgwood commented Oct 7, 2020

Thanks @loic5! I suggested a few phrasing changes.

@zigarn
Copy link

zigarn commented Oct 7, 2020

Ah ah, @loic5: this give you an occasion to play with the apply suggestion of GitHub, and also idea of PR for the repository you copied this file from 😜

loic5 and others added 2 commits October 7, 2020 11:38
Co-authored-by: Hugo Wood <[email protected]>
Co-authored-by: Hugo Wood <[email protected]>
@hgwood hgwood merged commit 3157837 into zenika-open-source:master Oct 7, 2020
@loic5
Copy link
Contributor Author

loic5 commented Oct 7, 2020

Ah ah, @loic5: this give you an occasion to play with the apply suggestion of GitHub, and also idea of PR for the repository you copied this file from 😜

Exactly !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants