Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Move client folder #184

Merged
merged 1 commit into from
Feb 27, 2019
Merged

🚚 Move client folder #184

merged 1 commit into from
Feb 27, 2019

Conversation

Errorname
Copy link
Contributor

@Errorname Errorname commented Feb 26, 2019

Currently, we have the following folders and files hierarchy:

/
  .circleci/
  .github/
  docs/
  public/
  server/
  src/
  .env
  .env.local.example
  .eslintrc
  .gitignore
  LICENSE.md
  README.md
  doczrc.js
  package-lock.json
  package.json

There is multiple problem with this hierarchy:

  • The client is at root level, while the server is in its own folder
  • Client files and folders at root level are mixed with unrelated files and folders
  • Client package-json scripts handles more than client-only logic (eg: docs stuff)
  • It isn't clear where we should add new folders for new "parts" of FAQ (eg: "landing" (landing page/website), "cli" (Create a CLI to simplify developer tasks #183), "status" (status website), "analytics" (analytics website))

This PR proposes the following hierarchy:

/
  .circleci/
  .github/
  client/
  docs/
  server/
  .gitignore
  LICENSE.md
  README.md

Each part will have its own package.json file. (Which is were #183 can be useful)

In the future, with the new "parts" of FAQ, this would look like this:

/
  .circleci/
  .github/
  analytics/
  cli/
  client/
  docs/
  landing/
  server/
  status/
  .gitignore
  LICENSE.md
  README.md

@Errorname Errorname requested a review from hgwood February 26, 2019 15:59
Copy link
Contributor

@hgwood hgwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Errorname Errorname merged commit c4be601 into master Feb 27, 2019
@Errorname Errorname deleted the move-client-folder branch February 27, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants