-
Notifications
You must be signed in to change notification settings - Fork 90
Feature/enable zf development mode just like in ZendSkeletonApp #105
Feature/enable zf development mode just like in ZendSkeletonApp #105
Conversation
Should we include the error_reporting? // when all else fails, kindly show me the bugs :)
if ($config['debug']) {
error_reporting(E_ALL);
ini_set("display_errors", 1);
} Purpose: Making sure that what you commit as production code is clean and Uncle Bob will be happy 👍 😂 |
You've got whoops to catch errors. Things that needs to be addressed:
Maybe we should rename the whoops option to |
// Development mode enabled | ||
if (file_exists(__DIR__ . '/../config/development.config.php')) { | ||
$config = ArrayUtils::merge($config, require __DIR__ . '/../config/development.config.php'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would place this after the block that caches configuration; we likely should never cache development configuration.
I agree with all points that @xtreamwayz notes. If we get those resolved, I'd be happy to incorporate this, however! |
@gabbydgab Thanx for this. This feature is included in #54. |
Based on my suggestion in #104
Following changes are: