chore: add zendesk-dev.com domain to allow for scooter #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zFlabmonsta
commented
Feb 12, 2024
| @@ -283,6 +283,7 @@ function isOriginValid (origin) { | |||
| /^https:\/\/.+\.zd-dev\.com$/, | |||
| /^https:\/\/.+\.zd-master\.com$/, | |||
| /^https:\/\/.+\.zendesk-staging\.com$/, | |||
| /^https:\/\/.+\.zendesk-dev\.com$/, | |||
There was a problem hiding this comment.
decrease the scope to specifc region. Currently there are 2 regions
.euc1.scooter.zendesk-dev.com
.usw2.scooter.zendesk-dev.com
and a third in apac is on its way. https://zendesk.atlassian.net/browse/PLAN-7053
There was a problem hiding this comment.
Domain level looks fine to me
Shengming-Yan
approved these changes
Feb 12, 2024
zFlabmonsta
force-pushed
the
zflabmonsta/scooter
branch
from
08e3c4c to
ec1f4eb
Compare
lib/client.js
Outdated
| @@ -283,6 +283,7 @@ function isOriginValid (origin) { | |||
| /^https:\/\/.+\.zd-dev\.com$/, | |||
| /^https:\/\/.+\.zd-master\.com$/, | |||
| /^https:\/\/.+\.zendesk-staging\.com$/, | |||
| /^https:\/\/.+[euc1|usw2]\.scooter\.zendesk-dev\.com$/, | |||
There was a problem hiding this comment.
Sorry, it seems my previous comment make you confusion. I was trying to say domain level(zendesk-dev.com) looks good enough. Not need to specify into subdomain level.
There was a problem hiding this comment.
Ah ok. I didnt see the comment from before 😅
anushkafka
approved these changes
Feb 12, 2024
zFlabmonsta
force-pushed
the
zflabmonsta/scooter
branch
from
ec1f4eb to
b53b07f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
/cc @zendesk/vegemite
Description
This PR contains whitelisting scooter domain to the allow list.
Tasks
References
DevQA Steps
NOTE: DevQA steps are to be actioned only once code has been reviewed and approved.
Risks
Rollback Plan