Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pane.created event POC #211

Conversation

josh-mo
Copy link

@josh-mo josh-mo commented Oct 30, 2023

✌️

/cc @zendesk/vegemite

Description

Describe the original problem and the changes made on this PR.

Tasks

  • Include comments/inline docs where appropriate
  • Add unit tests
  • Update changelog here
  • Add label from one of 'patch'/'minor'/'major' if you want to create a release when merged

References

DevQA Steps

NOTE: DevQA steps are to be actioned only once code has been reviewed and approved.

Risks

  • [HIGH | medium | low] Does it work across browsers (including IE!)?
  • [HIGH | medium | low] Does it work in the different products (Support, Chat, Connect)?
  • [HIGH | medium | low] Are there any performance implications?
  • [HIGH | medium | low] Any security risks?
  • [HIGH | medium | low] What features does this touch?

Rollback Plan

  1. Quickly roll back to the prior release so that customers can refresh to resolve their issue.
  2. Revert this PR to restore the master branch to a deployable green state.
  3. Notify the author.

@josh-mo
Copy link
Author

josh-mo commented Oct 30, 2023

POC only

@josh-mo josh-mo closed this Oct 30, 2023
@@ -355,6 +355,7 @@ export default class Client {
this._idleState.addObserver(debounce(() => {
this.postMessage('session.live')
}, 1000))
this.postMessage('client.app.registered');
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send postMessage to ZAF when sdk received app.registered event from zaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant