Merge pull request #207 from zendesk/wxing/clear-request-handlers

Clear handlers of request:X.done and request:X.fail of the request
zendesk · Jun 19, 2023 · a059fe1 · a059fe1
2 parents ae7cdab + 1f782af
commit a059fe1
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -556,13 +556,23 @@ export default class Client {
         options = { url: options }
       }
 
-      this.on(requestKey + '.done', (evt) => {
+      const doneEventKey = `${requestKey}.done`
+      const failEventKey = `${requestKey}.fail`
+
+      const doneHandler = (evt) => {
         resolve.apply(this, evt.responseArgs)
-      })
+        this.off(failEventKey, failHandler)
+        this.off(doneEventKey, doneHandler)
+      }
 
-      this.on(requestKey + '.fail', (evt) => {
+      const failHandler = (evt) => {
         reject.apply(this, evt.responseArgs)
-      })
+        this.off(failEventKey, failHandler)
+        this.off(doneEventKey, doneHandler)
+      }
+
+      this.on(doneEventKey, doneHandler)
+      this.on(failEventKey, failHandler)
 
       this.postMessage(requestKey, options)
     })