Match some RSP audio functions #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yanis002
approved these changes
Sep 21, 2024
| static s32 nFirstTime_2648 = 0x00000001; | ||
| static s32 nFirstTime_2757 = 0x00000001; | ||
| static s32 nFirstTime_2796 = 0x00000001; | ||
| static bool nFirstTime_2148 = true; |
There was a problem hiding this comment.
maybe add //! TODO: move to the functions or something like that, it seems to be static variables inside functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly
rspParseABI[1-4]and some of its helper functions. I mostly gave up on documenting because I'm not sure which ABI corresponds to which games (although I think ABI1 is sm64 and ABI2 is oot at least)