Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the rest of runtime and libc #183

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Match the rest of runtime and libc #183

merged 2 commits into from
Sep 20, 2024

Conversation

cadmic
Copy link
Collaborator

@cadmic cadmic commented Sep 20, 2024

No description provided.

Copy link
Collaborator

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👀

libc/stdarg.h Outdated
@@ -14,6 +14,10 @@ extern void __builtin_va_info(void*);

void* __va_arg(va_list v_list, unsigned char type);

#if !__MWERKS__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this set to 0 or 1? I thought it was a simple define you could check through #ifdef/#ifndef

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that I think about it it's probably the same thing in the end so it's probably fine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh I'm not sure why past me wrote it this way, I changed it to ifndef

@cadmic cadmic merged commit 40e9f6f into zeldaret:main Sep 20, 2024
2 checks passed
@cadmic cadmic deleted the libc branch September 20, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants