Remove asm-processor in favor of preprocess.sh #1760
+1,760
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensldm
added
Tooling
Needs-second-approval
AngheloAlf
reviewed
Dec 15, 2024
|
Looks like this might cause issues for Macs (https://discord.com/channels/688807550715560050/688851337085190255/1317981637086154783). Converted the PR to a draft until I can take a look at it. |
|
Okay, ported over the mac iconv fixes from OoT, so I believe this should work for them as well (don't know for sure as I don't have a Mac). |
|
Seems to work fine on an M1 mac (https://discord.com/channels/688807550715560050/688851976746041391/1318678178642006027) |
AngheloAlf
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies over preprocess.sh and related tools from OoT to remove the use of asm-processor.
This also allows for the use of
#pragma increment_block_numberinstead of#include prevent_bss_reordering.handtools/fix_bss.py.Note I've also changed extract_assets.py so zapd now uses the CS_FLOATS macro.