Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage migrations for Combinatorial Tokens Upgrade #1401

Open
wants to merge 11 commits into
base: develop-combo-futarchy
Choose a base branch
from

Conversation

Chralt98
Copy link
Member

What does it do?

This adds the necessary storage migrations for the changes of #1364

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:in-progress The pull requests is currently being worked on label Dec 12, 2024
@Chralt98 Chralt98 self-assigned this Dec 12, 2024
@Chralt98 Chralt98 changed the base branch from main to develop-combo-futarchy December 12, 2024 09:24
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Dec 18, 2024
@Chralt98 Chralt98 marked this pull request as ready for review December 18, 2024 11:42
@Chralt98 Chralt98 requested a review from sea212 as a code owner December 18, 2024 11:42
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Dec 18, 2024
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Dec 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.95215% with 21 lines in your changes missing coverage. Please review.

Project coverage is 93.51%. Comparing base (93f0663) to head (a932be0).

Files with missing lines Patch % Lines
zrml/neo-swaps/src/migration.rs 89.95% 21 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           develop-combo-futarchy    #1401      +/-   ##
==========================================================
- Coverage                   93.53%   93.51%   -0.03%     
==========================================================
  Files                         178      179       +1     
  Lines                       34547    34756     +209     
==========================================================
+ Hits                        32315    32503     +188     
- Misses                       2232     2253      +21     
Flag Coverage Δ
tests 93.51% <89.95%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chralt98 Chralt98 added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Dec 19, 2024
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:review-needed The pull request requires reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants