Fix post upgrade balance transfer IT test #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-v0.5.6 #1400 +/- ##
=================================================
Coverage ? 93.19%
=================================================
Files ? 131
Lines ? 29245
Branches ? 0
=================================================
Hits ? 27256
Misses ? 1989
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mergify
bot
added
s:in-progress
Chralt98
added
s:review-needed
mergify
bot
added
s:in-progress
Chralt98
added
s:review-needed
mergify
bot
added
s:in-progress
saboonikhil
approved these changes
Dec 13, 2024
saboonikhil
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR fixes the integration test that ensures balance transfers can be made after the upgrade. Because of the existential deposit increase, the balance transfer test had to be adjusted too.
What important points should reviewers know?
The chopsticks dependency needed to be updated in order to fix the timeout error.
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References