Increase existential deposit #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
s:in-progress
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1397 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 131 131
Lines 29241 29241
=======================================
Hits 27252 27252
Misses 1989 1989
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maltekliemann
added
s:review-needed
Chralt98
reviewed
Dec 3, 2024
mergify
bot
added
s:in-progress
maltekliemann
added
s:review-needed
maltekliemann
added
s:review-needed
maltekliemann
added
s:review-needed
Chralt98
approved these changes
Dec 4, 2024
| pub const ContractsDepositPerByte: Balance = deposit(0,1); | ||
| pub const ContractsDepositPerItem: Balance = deposit(1,0); | ||
| pub const ContractsMaxCodeLen: u32 = 123 * 1024; | ||
| pub const ContractsMaxDebugBufferLen: u32 = 2 * 1024 * 1024; | ||
| pub const ContractsMaxDelegateDependencies: u32 = 32; |
There was a problem hiding this comment.
Why did you miss to remove ContractsMaxDelegateDependencies ?
There was a problem hiding this comment.
Ah, because of this. Might be worth to add a TODO with an issue to remove it as soon as the migration to remove contracts storage is done.
Comment on lines
+98
to
+111
| // `ContractInfo` struct that we need for `ClearContractsChildTries` but pallet-contracts | ||
| // doesn't expose publicly. | ||
| #[derive(Encode, Decode, Clone, PartialEq, Eq, RuntimeDebug, TypeInfo, MaxEncodedLen)] | ||
| pub struct ContractInfo { | ||
| pub trie_id: TrieId, | ||
| pub code_hash: CodeHash, | ||
| pub storage_bytes: u32, | ||
| pub storage_items: u32, | ||
| pub storage_byte_deposit: Balance, | ||
| pub storage_item_deposit: Balance, | ||
| pub storage_base_deposit: Balance, | ||
| pub delegate_dependencies: | ||
| BoundedBTreeMap<CodeHash, Balance, ContractsMaxDelegateDependencies>, | ||
| } |
maltekliemann
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References