Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused DealWithCampaignFees struct #1305

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Apr 5, 2024

What does it do?

See title

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@sea212 sea212 added the s:review-needed The pull request requires reviews label Apr 5, 2024
@sea212 sea212 added this to the v0.5.2 milestone Apr 5, 2024
@sea212 sea212 requested a review from Chralt98 April 5, 2024 12:55
@sea212 sea212 self-assigned this Apr 5, 2024
@maltekliemann maltekliemann added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (aa3f225) to head (804b36d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1305   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files         190      190           
  Lines       34493    34493           
=======================================
  Hits        31658    31658           
  Misses       2835     2835           
Flag Coverage Δ
tests 91.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Apr 5, 2024
@mergify mergify bot merged commit 2d0277b into main Apr 5, 2024
14 checks passed
@mergify mergify bot deleted the sea212-remove-dead-code branch April 5, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants