Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize prediction-markets tests #1240

Closed
wants to merge 33 commits into from
Closed

Reorganize prediction-markets tests #1240

wants to merge 33 commits into from

Conversation

maltekliemann
Copy link
Contributor

What does it do?

Restructures prediction-market tests into separate files, eliminates duplicates, makes get() calls through Config instead of directly calling mock constants and adds TODOs pointing to missing tests, which will be filled in in future PRs.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@maltekliemann
Rename tests.rs to old_tests.rs to avoid naming conflicts
15bee2c
@maltekliemann
Move buy_complete_set tests to new tests
1b34302
@maltekliemann
Clean up buy_complete_set tests
8908952
@maltekliemann
Extract sell_complete_set_tests
3bd0f73
@maltekliemann
Clean up sell_complete_set tests
4be0484
@maltekliemann
Extract admin_move_market_to_closed tests
62c5915
@maltekliemann
Extract create_market tests
edf6aea
@maltekliemann
Extract admin_move_market_to_resolved tests
cbf78f6
@maltekliemann
Remove superfluous test
8df142f
@maltekliemann
Extract more create_market tests
8a73e99
@maltekliemann
Extract approve_market tests
4d04fdb
@maltekliemann
Extract edit_market tests
29bafe4
@maltekliemann
Extract edit_market tests
dd68842
@maltekliemann
Merge branch 'main' into mkl-pm-tests
4969d35
@maltekliemann
Add on_market_close tests
a3827ad
@maltekliemann
Extract manually_close_market tests
4352aa2
@maltekliemann
Extract on_initialize tests
9cb5dfb
@maltekliemann
Extract report tests
0f4b1f9
@maltekliemann
Extract dispute tests
7717b4e
@maltekliemann
Extract schedule_early_close tests
87c1dc3
@maltekliemann
Extract dispute_early_close tests
18e62b0
@maltekliemann
Extract reject_early_close tests
5efef55
@maltekliemann
Extract more dispute tests
cd7e813
@maltekliemann
Extract close_trusted_market tests
fc57725
@maltekliemann
Extract start_global_dispute tests
0526b48
@maltekliemann
Extract redeem_shares tests and add missing tests
27f420e
@maltekliemann
Extract on_resolution and additional redeem_shares tests
2bc4b41
@maltekliemann
Move integration tests into new test module
c0e8a34
@maltekliemann
Automatically set block to 1 at the start of test
fe30d80
@maltekliemann
Replace crate::Config with Config
c7298b8
@maltekliemann maltekliemann self-assigned this Jan 21, 2024
@maltekliemann maltekliemann added the s:review-needed The pull request requires reviews label Jan 21, 2024
@maltekliemann maltekliemann requested a review from sea212 as a code owner January 21, 2024 19:24
@maltekliemann maltekliemann removed the s:review-needed The pull request requires reviews label Jan 21, 2024
@maltekliemann
Copy link
Contributor Author

Closing because I'm pushing in the wrong branch.

@maltekliemann maltekliemann deleted the mkl-pm-tests branch February 23, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea212 sea212 Awaiting requested review from sea212 sea212 is a code owner

Assignees

@maltekliemann maltekliemann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maltekliemann