-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moonwall integration tests #1194
Add moonwall integration tests #1194
Conversation
Don't forget to add your tests to the CI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## chralt98-add-integration-tests #1194 +/- ##
===============================================================
Coverage 93.25% 93.25%
===============================================================
Files 121 121
Lines 34162 34162
===============================================================
Hits 31858 31858
Misses 2304 2304
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
integration-tests/README.md
Outdated
|
||
Useful for integration testing: | ||
|
||
- `./integration-tests/scripts/deploy-zombienet.sh` - Deploy a local relay-parachain network for zombienet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting this on Ubuntu VM. I did call cargo build ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What did you get?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the same error like previously. It's because you are missing the polkadot binary.
Can you try running the following first?
cd integration-tests
./scripts/download-polkadot.sh
Will add this to the documentation properly, if everything works fine on your side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly what you can see there. It starts the network by spawning a zeitgeist node (alice) and two polkadot validators. You can do whatever you want on polkadot js now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integration-tests/README.md
Outdated
- `./integration-tests/scripts/deploy-zombienet.sh` - Deploy a local relay-parachain network for zombienet. | ||
- `pnpm chopsticks xcm -r polkadot -p ./configs/hydradx.yml -p ./configs/zeitgeist.yml` - Deploy a local relay-parachain fork network via chopsticks to test XCM. | ||
- `./integration-tests/scripts/deploy-zombienet.sh --test` - Run ZNDSL zombienet tests on a local relay-parachain network. | ||
- `pnpm exec moonwall test zombienet_zeitgeist_upgrade` - Test Zeitgeist runtime upgrade on zombienet for the local network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This often takes a little bit longer. It's often on my machine too: fetching metrics
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the fact that it says "Error" shouldn't concern me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't do anything about it. It is just stated, because the nodes are not ready to fetch the metrics yet. It's because the nodes are still in the process of starting the metric endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, we should add this to the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integration-tests/README.md
Outdated
- `./integration-tests/scripts/deploy_zombienet.sh --test` - Run ZNDSL zombienet tests on a local relay-parachain network. | ||
- `pnpm exec moonwall test chopsticks_zeitgeist_hydra_xcm_tests` - XCM Tests from Zeitgeist to HydraDX. | ||
- `pnpm exec moonwall test zombienet_zeitgeist_upgrade` - Test Zeitgeist runtime upgrade on zombienet for the local network. | ||
- `pnpm exec moonwall test chopsticks_zeitgeist_upgrade` - Test Zeitgeist runtime upgrade on chopsticks for the live network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one passes on the Linux VM.
6240fe3
into
chralt98-add-integration-tests
What does it do?
Fixes #1186
It adds integration tests for our parachain setup and current live chains (main-net and battery-station) and uses those in our CI.
What important points should reviewers know?
This PR depends on #1192
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References