Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Parimutuel markets #1138

Merged
merged 105 commits into from
Oct 25, 2023
Merged

Implement Parimutuel markets #1138

merged 105 commits into from
Oct 25, 2023

Conversation

Chralt98
Copy link
Member

@Chralt98 Chralt98 commented Oct 9, 2023 •
edited by maltekliemann
Loading

What does it do?

Implements a simple version of the non-dynamic parimutuels market maker concept.

What important points should reviewers know?

Depends on #1137

Is there something left for follow-up PRs?

Implement a dynamic parimutuel market maker system.

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:in-progress The pull requests is currently being worked on label Oct 9, 2023
@Chralt98 Chralt98 self-assigned this Oct 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

This pull request is now in conflicts. Could you fix it @Chralt98? 🙏

@mergify mergify bot added s:revision-needed The pull requests must be revised and removed s:in-progress The pull requests is currently being worked on labels Oct 11, 2023
@Chralt98 Chralt98 added s:in-progress The pull requests is currently being worked on and removed s:revision-needed The pull requests must be revised labels Oct 12, 2023
@mergify mergify bot added s:revision-needed The pull requests must be revised and removed s:in-progress The pull requests is currently being worked on labels Oct 12, 2023
@Chralt98 Chralt98 requested a review from sea212 October 24, 2023 11:22
@sea212 sea212 added i:spec-changed ⚠️ Implies change in spec version i:transactions-changed ⚠️ Implies change in transaction version labels Oct 24, 2023
sea212
sea212 previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@sea212 sea212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid

@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Oct 25, 2023
@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Oct 25, 2023
@Chralt98 Chralt98 merged commit 52a3063 into main Oct 25, 2023
21 of 23 checks passed
@Chralt98 Chralt98 deleted the chralt98-parimutuel branch October 25, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea212 sea212 sea212 approved these changes

@maltekliemann maltekliemann Awaiting requested review from maltekliemann

Assignees

@Chralt98 Chralt98

Labels
i:spec-changed ⚠️ Implies change in spec version i:transactions-changed ⚠️ Implies change in transaction version s:accepted This pull request is ready for merge
Projects
None yet
Milestone
v0.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Chralt98 @codecov-commenter @maltekliemann @sea212