Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update runners for each workflow job #1134

Closed
wants to merge 17 commits into from

Conversation

samuelarogbonlo
Copy link
Contributor

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@samuelarogbonlo samuelarogbonlo self-assigned this Oct 2, 2023
@samuelarogbonlo samuelarogbonlo added the s:review-needed The pull request requires reviews label Oct 2, 2023
@samuelarogbonlo samuelarogbonlo requested a review from sea212 October 2, 2023 13:41
Copy link
Member

@sea212 sea212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following jobs are also failing due to missing disk space and require a self hosted runner:

Workflow: Rust
Jobs:

  • Quick check benchmarks
  • Clippy
  • Test parachain build

.github/workflows/docker-hub-parachain.yml Outdated Show resolved Hide resolved
.github/workflows/docker-hub-parachain.yml Outdated Show resolved Hide resolved
.github/workflows/docker-hub.yml Outdated Show resolved Hide resolved
.github/workflows/docker-hub.yml Show resolved Hide resolved
@samuelarogbonlo samuelarogbonlo requested a review from sea212 October 5, 2023 11:39
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Oct 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e2cacc0) 93.49% compared to head (ef8e39f) 93.54%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
+ Coverage   93.49%   93.54%   +0.05%     
==========================================
  Files          94      114      +20     
  Lines       28645    32558    +3913     
==========================================
+ Hits        26783    30458    +3675     
- Misses       1862     2100     +238     
Flag Coverage Δ
tests 93.54% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea212 sea212 added s:revision-needed The pull requests must be revised and removed s:review-needed The pull request requires reviews labels Oct 6, 2023
@samuelarogbonlo
Copy link
Contributor Author

@sea212 For the failing jobs, they all had a common error: cargo not found. This could've been as a result of some dependencies getting installed in the Github-hosted runners (ubuntu-latest), and the jobs running in our self-hosted runners (self-hosted, zeitgeist-runner). For now, I've set all jobs to run on self-hosted, zeitgeist-runner.

@samuelarogbonlo samuelarogbonlo added s:review-needed The pull request requires reviews and removed s:revision-needed The pull requests must be revised s:review-needed The pull request requires reviews labels Oct 12, 2023
@samuelarogbonlo samuelarogbonlo added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Oct 12, 2023
@samuelarogbonlo samuelarogbonlo added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Oct 12, 2023
@samuelarogbonlo samuelarogbonlo added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Oct 12, 2023
@samuelarogbonlo samuelarogbonlo added the s:review-needed The pull request requires reviews label Oct 15, 2023
@samuelarogbonlo samuelarogbonlo added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Oct 16, 2023
@sea212 sea212 added this to the v0.4.2 milestone Oct 17, 2023
@sea212 sea212 modified the milestones: v0.4.2, v0.4.3 Oct 25, 2023
@samuelarogbonlo samuelarogbonlo added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Nov 9, 2023
@sea212 sea212 assigned sea212 and unassigned samuelarogbonlo Dec 7, 2023
@sea212 sea212 added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Dec 7, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Dec 11, 2023
@Chralt98
Copy link
Member

What are the CI failures here? Why did you approve @maltekliemann, if you saw the CI to fail?

Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the following github actions be removed then?

      # No disk space: https://github.com/zeitgeistpm/zeitgeist/actions/runs/5085081984/jobs/9144298675?pr=1006
      # Workaround: https://github.com/actions/runner-images/issues/2840#issuecomment-790492173
      - name: Free up disk space on GitHub hosted runners
        run: |
          # Ensure context is GitHub hosted runner
          # https://docs.github.com/en/actions/learn-github-actions/contexts#runner-context
          if [[ "${{ runner.name }}" == "GitHub Actions"* ]]; then
            echo "Freeing up space in GitHub hosted runner"
            sudo rm -rf /usr/share/dotnet
            sudo rm -rf /opt/ghc
            sudo rm -rf "/usr/local/share/boost"
            sudo rm -rf "$AGENT_TOOLSDIRECTORY"
          fi

@sea212
Copy link
Member

sea212 commented Dec 16, 2023

What are the CI failures here? Why did you approve @maltekliemann, if you saw the CI to fail?

Previously the CI has passed. We'll have to look into it.

@sea212 sea212 added s:abandoned This pull request is abandoned and removed s:review-needed The pull request requires reviews labels Jan 4, 2024
@sea212
Copy link
Member

sea212 commented Jan 4, 2024

Pipeline successfully runs through again using GitHub hosted runners. Closing for now.

@sea212 sea212 closed this Jan 4, 2024
@sea212 sea212 removed this from the v0.5.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:abandoned This pull request is abandoned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants