Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix taplo build #1126

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix taplo build #1126

merged 1 commit into from
Sep 27, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Sep 27, 2023

What does it do?

  • Uses a specific rev of Taplo that contains a hotfix which fixed a broken build.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@sea212 sea212 added the s:review-needed The pull request requires reviews label Sep 27, 2023
@sea212 sea212 added this to the v0.4.1 milestone Sep 27, 2023
@sea212 sea212 self-assigned this Sep 27, 2023
@sea212 sea212 changed the title Use taplo rev that contains hotfix Fix taplo build Sep 27, 2023
@maltekliemann maltekliemann added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Sep 27, 2023
@sea212 sea212 merged commit ac4e05e into main Sep 27, 2023
21 of 23 checks passed
@sea212 sea212 deleted the sea212-fix-taplo-build branch September 27, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltekliemann maltekliemann maltekliemann approved these changes

Assignees

@sea212 sea212

Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sea212 @maltekliemann