Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taplo workflow #1102

Closed
wants to merge 7 commits into from
Closed

Fix taplo workflow #1102

wants to merge 7 commits into from

Conversation

maltekliemann
Copy link
Contributor

What does it do?

Fixes the recent compiler issues encountered when trying to run the taplo workflow.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@maltekliemann maltekliemann self-assigned this Sep 12, 2023
@maltekliemann maltekliemann added the s:review-needed The pull request requires reviews label Sep 12, 2023
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Sep 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.18% 🎉

Comparison is base (8654030) 93.34% compared to head (cdfcc36) 93.53%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   93.34%   93.53%   +0.18%     
==========================================
  Files          95       96       +1     
  Lines       27996    29154    +1158     
==========================================
+ Hits        26134    27270    +1136     
- Misses       1862     1884      +22     
Flag Coverage Δ
tests 93.53% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Sep 12, 2023
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Sep 12, 2023
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Sep 12, 2023
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Sep 12, 2023
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Sep 12, 2023
@maltekliemann
Copy link
Contributor Author

Closed because this isn't going anywhere.

@maltekliemann maltekliemann added s:abandoned This pull request is abandoned and removed s:review-needed The pull request requires reviews labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:abandoned This pull request is abandoned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants