Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize number formatting #2438

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

Localize number formatting #2438

wants to merge 3 commits into from

Conversation

robhyrk
Copy link
Contributor

@robhyrk robhyrk commented Jun 4, 2024

closes #2059

@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 8:14pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
wsx ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 8:14pm

Robiquet
Robiquet reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@Robiquet Robiquet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this will close #2059 as it doesn't cover the formatting of number inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robiquet Robiquet Robiquet left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of period/comma as decimal point is inconsistent across the app
2 participants
@robhyrk @Robiquet