Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account dropdown being under notifications #2402

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Fix account dropdown being under notifications #2402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a506d0
Set correct z index for notification
yornaath Apr 25, 2024
30190f0
Update yarn.lock
yornaath Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ui/NotificationCenter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const NotificationCenter = () => {
const { notifications, removeNotification } = useNotifications();

return (
<div className="pointer-events-none fixed top-0 z-[100] h-full w-full">
<div className="pointer-events-none fixed top-0 z-[20] h-full w-full">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that this doesn't cause the notifications to drop behind anything? I'm thinking it might fall behind the modal overlay

<div className="flex flex-row justify-end pt-20">
<div className="relative flex flex-1 flex-col items-end px-4">
<AnimatePresence mode="sync" presenceAffectsLayout>
Expand Down
9 changes: 1 addition & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3207,7 +3207,7 @@ __metadata:
languageName: node
linkType: hard

"@scure/base@npm:^1.1.1":
"@scure/base@npm:^1.1.1, @scure/base@npm:~1.1.4":
version: 1.1.6
resolution: "@scure/base@npm:1.1.6"
checksum: d6deaae91deba99e87939af9e55d80edba302674983f32bba57f942e22b1726a83c62dc50d8f4370a5d5d35a212dda167fb169f4b0d0c297488d8604608fc3d3
Expand All @@ -3228,13 +3228,6 @@ __metadata:
languageName: node
linkType: hard

"@scure/base@npm:~1.1.4":
version: 1.1.6
resolution: "@scure/base@npm:1.1.6"
checksum: d6deaae91deba99e87939af9e55d80edba302674983f32bba57f942e22b1726a83c62dc50d8f4370a5d5d35a212dda167fb169f4b0d0c297488d8604608fc3d3
languageName: node
linkType: hard

"@scure/bip32@npm:1.3.1":
version: 1.3.1
resolution: "@scure/bip32@npm:1.3.1"
Expand Down
Loading