Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch embed on market page #2376

Merged
merged 10 commits into from
May 20, 2024
Merged

Twitch embed on market page #2376

merged 10 commits into from
May 20, 2024

Conversation

yornaath
Copy link
Contributor

@yornaath yornaath commented Mar 26, 2024

Added twitch embedded stream on market page.

  • Show stream tab if cms metadata has stream url or channelname.
  • Highlight stream tab button if channel is live.
  • Display stream tab by default if channel is live.
  • Added streamer url/name validation in the sanity cms.

Fixes #2369

@yornaath yornaath requested a review from Robiquet March 26, 2024 12:05
Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 11:45am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
wsx ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 11:45am

Copy link
Member

@Robiquet Robiquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charts don't display anymore, for example:
https://ui-git-tr-twitch-embed-zeitgeistpm.vercel.app/markets/809

@Robiquet Robiquet merged commit f782b30 into staging May 20, 2024
7 checks passed
@Robiquet Robiquet deleted the tr-twitch-embed branch May 20, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display twitch stream on market page
2 participants