Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map error type to message #1782

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Map error type to message #1782

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc95bca
Map error type to message
Robiquet Sep 11, 2023
8fb777e
catch polling function errors
Robiquet Sep 18, 2023
8b630bd
await cryptoWaitReady
Robiquet Sep 19, 2023
097af55
revert and fix
Robiquet Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions components/account/WalletSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,10 @@ const WalletSelect = () => {
)}
{hasError && (
<div className="text-vermilion ml-auto text-ztg-12-120 w-ztg-275">
{error.type === "NoAccounts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this actually change? Since error type should only be one of two types it seems like the old code should cover all cases?

Copy link
Member Author

@Robiquet Robiquet Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the types are probably wrong and not all errors are accounted for. Even so, I don't think the previous code is good practice as it assumes that there will only ever be 2 error types

? "No accounts on this wallet. Please add account in wallet extension."
: "Not allowed to interact with extension. Please change permission settings."}
{error.type === "NoAccounts" &&
"No accounts on this wallet. Please add account in wallet extension."}
{error.type === "InteractionDenied" &&
"Not allowed to interact with extension. Please change permission settings."}
</div>
)}
</div>
Expand Down