Merge pull request #1852 from zeitgeistpm/tr-coindesk-2

Configurable market tags
zeitgeistpm · Oct 4, 2023 · d22dcc5 · d22dcc5
2 parents 257bc70 + 6b7e4fa
commit d22dcc5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/.env.example b/.env.example
@@ -40,3 +40,6 @@ NEXT_PUBLIC_SITE_URL=http://localhost:3000
 
 # disable grillchat
 NEXT_PUBLIC_GRILLCHAT_DISABLE=true
+
+NEXT_PUBLIC_OTHER_TAGS=["Coindesk"]
+
diff --git a/lib/constants/markets.ts b/lib/constants/markets.ts
@@ -1,5 +1,4 @@
 import { EMarketStatus, MarketStatus } from "lib/types/markets";
-import { environment } from ".";
 
 const prodTags = [
   "Politics",
@@ -13,12 +12,11 @@ const prodTags = [
   "E-Sports",
 ] as const;
 
-const otherTags = ["Coindesk"] as const;
+const otherTags = process.env.NEXT_PUBLIC_OTHER_TAGS
+  ? JSON.parse(process.env.NEXT_PUBLIC_OTHER_TAGS)
+  : [];
 
-export const defaultTags = [
-  ...prodTags,
-  ...(environment !== "production" ? otherTags : []),
-] as const;
+export const defaultTags = [...prodTags, ...otherTags] as const;
 
 export type SupportedTag = typeof defaultTags[number];
 

diff --git a/lib/types/market-filter.ts b/lib/types/market-filter.ts
@@ -14,7 +14,7 @@ export type MarketOrderByOption = {
   value: MarketsOrderBy;
 };
 
-export type MarketFilterTagLabel = typeof CATEGORIES[number]["name"];
+export type MarketFilterTagLabel = typeof CATEGORIES[number]["name"] | string;
 
 export type MarketFilterStatusLabel = MarketStatus;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -40,3 +40,6 @@ NEXT_PUBLIC_SITE_URL=http://localhost:3000

		# disable grillchat
		NEXT_PUBLIC_GRILLCHAT_DISABLE=true

		NEXT_PUBLIC_OTHER_TAGS=["Coindesk"]