Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential segfault with stream iterators. #1923

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Fix potential segfault with stream iterators. #1923

merged 2 commits into from
Nov 25, 2024

Commits on Nov 25, 2024

  1. Add regression tests triggering #1918.

    @rsmmr
    rsmmr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ff34c28 View commit details
    Browse the repository at this point in the history

  2. Fix potential segfault with stream iterators. 

    When trimming off the beginning of a stream, an existing iterator
could end up dereferencing its internal chunk pointer even if the
chunk now no longer existed. The issue was inside the
increment/decrement operations, which didn't check if the *current*
iterator offset was still valid (because only then the current chunk
is guaranteed to be valid too).

Closes #1918.
    @rsmmr
    rsmmr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    153eca3 View commit details
    Browse the repository at this point in the history