Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chaos files #600

Merged
3 commits merged into from
Dec 23, 2022
Merged

Remove chaos files #600

3 commits merged into from
Dec 23, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Mar 11, 2022

This PR removes the chaos files.

Most of the files have already been moved to chaos test. However, some files are duplicated which leads to confusion and possibly to unintended outcomes: zeebe-io/zeebe-chaos#123

With the upcoming changes (i.e. Deepthi implementing another test) this repo will be slimmed down to only provide the bare testbench, which is then extensible by independently deployed tests (chaos tests, the Deepthi test).

@Zelldon Happy to discuss this direction of travel with you, if you have any objections. This is not set in stone. Since you were off this week, I didn't yet have a chance to align. This PR was created under the assumption that you agree to this approach.

@Zelldon I checked whether all the stuff I removed here is available in chaos-test. This seems true for the BPMN models and the deployment descriptors. However, I didn't immediately find any scripts to actually deploy the chaos workers. So this logic might have to be moved, or we just drop the last commit for a time being.

These have been moved to zeebe-chaos project a while ago
remove steps related to chaos worker deployment
@pihme pihme requested a review from ChrisKujawa March 11, 2022 09:28
Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pihme 👍

Makes total sense to me to remove the resources here :) 🙇

One model was missing, I added it to the chaos repo here zeebe-io/zeebe-chaos@494923a

You're right the deployment is currently done via this repo. I created an issue for it here zeebe-io/zeebe-chaos#125 So before this is done we shouldn't remove the deployment pipeline.

Do you think it makes sense to also remove some references from the docs and the images of the processes? 🤔

@pihme
Copy link
Contributor Author

pihme commented Mar 16, 2022

You're right the deployment is currently done via this repo. I created an issue for it here zeebe-io/zeebe-chaos#125 So before this is done we shouldn't remove the deployment pipeline.

I assigned this PR to you. You can merge it, when everything else is ready

Do you think it makes sense to also remove some references from the docs and the images of the processes? thinking

I am indifferent. I can see both a case for having one place to collect all documentation as I can see a case for removing the documentation, or just have a short hint here, which then points to the chaos repo. Whatever you feel works best.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2022

CLA assistant check
All committers have signed the CLA.

@ChrisKujawa
Copy link
Member

Please sign the CLA @pihme 😆 (never thought that I would say that to you 😆 )

@pihme pihme marked this pull request as draft April 1, 2022 13:18
@pihme
Copy link
Contributor Author

pihme commented Apr 1, 2022

Superseeded by #635 and then a new PR for the last commits - at the appropriate time

@ChrisKujawa ChrisKujawa marked this pull request as ready for review December 23, 2022 10:58
@ChrisKujawa
Copy link
Member

Merging it since we don't want to redeploy the old chaos workers anymore. We migrated to zbchaos v1.0.0 zeebe-io/zeebe-chaos#139

We will add a deploy pipeline in zeebe-chaos repo soon.

@ChrisKujawa
Copy link
Member

bors r+

@ghost
Copy link

ghost commented Dec 23, 2022

Build succeeded:

@ghost ghost merged commit ec0325e into main Dec 23, 2022
@ghost ghost deleted the remove-chaos-files branch December 23, 2022 11:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants