Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added devcontainer support #1560

Closed
wants to merge 2 commits into from
Closed

Conversation

niposch
Copy link

@niposch niposch commented Oct 5, 2023

I experimented with VS Code's devcontainers, and I was pleasantly surprised. Got this project up and running and even got the gui to show up on my Windows desktop despite the application running inside a docker container. Breakpoints also work.
image

Setup is pretty straight forward: have docker and VS Code + devcontainer extension installed.
Have the extension set up a dev container. It will set up the environment according to what is specified in the config files, which should make it a lot easier for people to start writing code without having to worry about setting everything up correctly, as the project can set itself up inside a docker container.

The setup works very well on Windows 11 (can't comment on older versions/other operating systems) but it would allow someone who isn't quite as familiar with how to get the project compiled/get all the dependencies installed up and running.

Feel free to reject if this isn't something the project is interested in.

@niposch niposch requested a review from trollixx as a code owner October 5, 2023 20:10
@trollixx
Copy link
Member

trollixx commented Oct 6, 2023

I haven't used devcontainer stuff in VS Code, but it seems to be not that different from building in WSL directly. I don't think IDE specific setup should be part of the main repo. A wiki page with instructions would be a better fit. Thanks.

@trollixx trollixx closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants