-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cancel button for each of the ongoing docset downloads #1027
base: main
Are you sure you want to change the base?
Add cancel button for each of the ongoing docset downloads #1027
Conversation
This fixes #712 |
9bad0d0
to
bfe266c
Compare
Thanks for the contribution! After a quick test I've noticed that the Cancel button stays visible during installation stage, but does not do anything. There are two options here: a) hide the button, b) make cancellation work for installation. The second requires more work, and should be submitted as a separate PR first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional comments.
It's been a while, and sorry for ignoring this for so long. I believe this should go in, and can be polished later. The base branch has changed a lot, and some files do not even exist any more. Rebasing is pretty much impossible, but copied changes seem to work as expected. Let me know if you want to update the PR yourself, otherwise I'll push my version (with attribution) in a couple of days. |
2a3b442
to
72c73b0
Compare
I've force-pushed the original changes without the insanity of merge commits. |
Preview
The
Cancel
button cancels the current download by emitting acancelButtonClicked
signal. This signal is emitted by overridingQStyledItemDelegate::editorEvent
and checking if theQMouseEvent
coordinates fall inside the cancel button bounds