Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new ice build'' #458

Closed
wants to merge 3 commits into from
Closed

Conversation

psprint
Copy link
Contributor

@psprint psprint commented Jan 12, 2023

Description

A new shorthand for null/as'null', configure'' and make'' ices.

Motivation and Context

Providing over and over again as'null' configure make'install' seems boring, so a new ice build'' has been introduced, that enables the three ices.

Related Issue(s)

#345 #334 #351

Usage examples

zi id-as from"gitlab.matrix.org" build for matrix-org/olm

instead of:

zi id-as as"null" from"gitlab.matrix.org" configure make'install' \
        for matrix-org/olm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@psprint
Copy link
Contributor Author

psprint commented Jan 12, 2023

I've also added null'' ice to be automatically triggered from build''. There is also nonull ice to block this.

@psprint
Copy link
Contributor Author

psprint commented Jan 29, 2023

@vladdoster: Why this PR isn't merged yet? It adds a pull-in of three ices via a single ice build''. Thus, it's an isolated, safe feature, basically 2 lines of code.

@vladdoster
Copy link
Member

Can you update the README.md?

@psprint
Copy link
Contributor Author

psprint commented Feb 9, 2023

Can you update the README.md?

@vladdoster: I've added description of build'' ice. I've also added a param'' ice alias env'', which allows to create a local -x … params. Didn't document it because the PR with param'' documentation isn't merged… #402

@vladdoster
Copy link
Member

vladdoster commented Apr 29, 2023

@psprint,

If I understand, this would basically force users to either use of lbin, sbin, and bin-gem-node with configure and make ices OR the build ice , right?


Using your example,

zi id-as from"gitlab.matrix.org" build for matrix-org/olm
  1. How do I pass different targets to make?

Say I want foo and bar targets, would it be:

zi id-as from"gitlab.matrix.org" build make'foo bar' for matrix-org/olm

or

zi id-as from"gitlab.matrix.org" build'foo bar' for matrix-org/olm

or is build just to abstract only the following condition:

configure make'install' as'null' 
  1. How do I pass flags to configure?

@psprint
Copy link
Contributor Author

psprint commented Apr 29, 2023 via email

Copy link
Member

@vladdoster vladdoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one test case for zunit in ices.zunit.

@github-actions github-actions bot added the tests label Jul 10, 2023
@psprint
Copy link
Contributor Author

psprint commented Jul 10, 2023

@vladdoster: I've added the test for build ice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants