Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐳 Add annexes to container #103

Merged
merged 3 commits into from
Nov 23, 2021
Merged

🐳 Add annexes to container #103

merged 3 commits into from
Nov 23, 2021

Conversation

pschmitt
Copy link
Member

@pschmitt pschmitt commented Nov 22, 2021

Here are a few updates to the docker container.

  • annexes get installed by default
  • zinit completion
  • at container build time @zinit-scheduler burst now installs to /data-static
  • at runtime /data-static gets copied over to /data. This is necessary because /data is meant to be backed via a volume (that's what we do in the zunit tests for instance to verify if we downloaded the files correctly)
  • most of the custom stuff (keys setup, annexes, the /data-static to /data file-copy etc) can now be disabled with NOTHING_FANCY=1 at runtime

@pschmitt pschmitt added enhancement New feature or request packaging Issue related to packaging & distribution labels Nov 22, 2021
@pschmitt pschmitt added this to the zinit 4.0 milestone Nov 22, 2021
@alichtman
Copy link
Member

Did this break something with zsh 5.1?

@pschmitt
Copy link
Member Author

Nah, that's just GH runners getting stuck.

@pschmitt
Copy link
Member Author

Seems related: zsh-users/zsh-docker#21

@pschmitt
Copy link
Member Author

zsh 5.1.1 is for sure a trouble-maker, its build log ends with "build failed":

https://github.com/zdharma-continuum/zinit/runs/4292608375?check_suite_focus=true#step:7:6245

The image kinda works though:

docker run -it --rm ghcr.io/pschmitt/zinit:zsh-5.1.1 zsh --version
zsh 5.1.1 (x86_64-unknown-linux-gnu)

Maybe we should drop zsh 5.1.1 altogether. zinit works best with 5.5.1+ anyway.

@alichtman
Copy link
Member

alichtman commented Nov 23, 2021

Yeah, let's drop it. It's old enough.

@pschmitt pschmitt merged commit 9a9be0c into main Nov 23, 2021
@pschmitt pschmitt deleted the docker-annexes branch November 23, 2021 10:17
@pschmitt
Copy link
Member Author

Done: 8881531

@pschmitt pschmitt restored the docker-annexes branch November 30, 2021 10:57
@vladdoster vladdoster deleted the docker-annexes branch December 27, 2021 10:48
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packaging Issue related to packaging & distribution released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants