-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐳 Add annexes to container #103
Conversation
Did this break something with zsh 5.1? |
Nah, that's just GH runners getting stuck. |
Seems related: zsh-users/zsh-docker#21 |
zsh 5.1.1 is for sure a trouble-maker, its build log ends with "build failed": https://github.com/zdharma-continuum/zinit/runs/4292608375?check_suite_focus=true#step:7:6245 The image kinda works though: docker run -it --rm ghcr.io/pschmitt/zinit:zsh-5.1.1 zsh --version
zsh 5.1.1 (x86_64-unknown-linux-gnu) Maybe we should drop zsh 5.1.1 altogether. zinit works best with 5.5.1+ anyway. |
Yeah, let's drop it. It's old enough. |
Done: 8881531 |
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Here are a few updates to the docker container.
@zinit-scheduler burst
now installs to/data-static
/data-static
gets copied over to/data
. This is necessary because/data
is meant to be backed via a volume (that's what we do in the zunit tests for instance to verify if we downloaded the files correctly)NOTHING_FANCY=1
at runtime