Add a Rho type, to distinguish from revealed nullifiers of spent notes.
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
add_rho_type
branch
3 times, most recently
from
9fe0e59 to
562896f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 80.49% 79.98% -0.52%
==========================================
Files 30 30
Lines 3158 3192 +34
==========================================
+ Hits 2542 2553 +11
- Misses 616 639 +23 ☔ View full report in Codecov by Sentry. |
nuttycom
changed the title
Rho type, to distinguish from revealed note nullifiers.Rho type, to distinguish from revealed nullifiers of spent notes.
str4d
requested changes
Mar 10, 2024
| @@ -9,7 +9,7 @@ pub(crate) struct TestVector { | |||
| pub(crate) rseed: [u8; 32], | |||
| pub(crate) memo: [u8; 512], | |||
| pub(crate) cv_net: [u8; 32], | |||
| pub(crate) rho: [u8; 32], | |||
| pub(crate) nf_old: [u8; 32], | |||
There was a problem hiding this comment.
If we're changing this, we need to also change it in zcash-test-vectors which is what generates this.
nuttycom
force-pushed
the
add_rho_type
branch
5 times, most recently
from
e0c9064 to
67f7e8f
Compare
nuttycom
force-pushed
the
add_rho_type
branch
2 times, most recently
from
a7b1dc7 to
25fe0e4
Compare
|
force-pushed to rebase to |
nuttycom
force-pushed
the
add_rho_type
branch
2 times, most recently
from
201b012 to
b2efb4c
Compare
|
This should probably be re-reviewed in its entirety at this point; by making it possible to create fake |
str4d
reviewed
Mar 12, 2024
This change removes the ability to construct a `Rho` value directly from the public API, except via deserialization from bytes (which is necessary in order to be able to serialize a `Note`). Ordinarily, `Rho` should be obtained either from an already-constructed `Note` or from an `Action` or `CompactAction`.
str4d
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.