using `clone` on type `RandomSeed` which implements the `Copy` trait

using `clone` on type `RandomSeed` which implements the `Copy` trait

usage of `Iterator::fold` on a type that implements `Try`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

doc list item without indentation

doc list item without indentation

doc list item without indentation

doc list item without indentation

the following explicit lifetimes could be elided: 'a

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

this expression creates a reference which is immediately dereferenced by the compiler

usage of `Iterator::fold` on a type that implements `Try`

usage of `Iterator::fold` on a type that implements `Try`

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

warning: using `clone` on type `RandomSeed` which implements the `Copy` trait --> src/builder.rs:298:25 | 298 | rseed: Some(self.note.rseed().clone()), | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.note.rseed()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: using `clone` on type `RandomSeed` which implements the `Copy` trait --> src/builder.rs:388:25 | 388 | rseed: Some(note.rseed().clone()), | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*note.rseed()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:625:14 | 625 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/builder.rs:797:18 | 797 | .zip(indexed_outputs.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/ea5e5ca0553095786f968671ab1c222e5b1df5c3/library/core/src/iter/traits/iterator.rs:589:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:820:10 | 820 | .fold(Some(ValueSum::zero()), |acc, action| { | __________^ 821 | | acc? + action.value_sum() 822 | | }) | |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: doc list item without indentation --> src/bundle/commitments.rs:19:5 | 19 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 19 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:21:5 | 21 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 21 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:23:5 | 23 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 23 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:24:5 | 24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | +++