Merge pull request #436 from zcash/incrementalmerkletree_0.7 #296
str4dAnnotations
10 warnings
|
usage of `Iterator::fold` on a type that implements `Try`:
src/lib.rs#L534
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:534:14
|
534 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/lib.rs#L615
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/builder.rs:615:18
|
615 | .zip(indexed_outputs.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/8c27a2ba6b21f3406a51118643080f0591949827/library/core/src/iter/traits/iterator.rs:598:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/lib.rs#L638
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:638:10
|
638 | .fold(Some(ValueSum::zero()), |acc, action| {
| __________^
639 | | acc? + action.value_sum()
640 | | })
| |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
doc list item without indentation:
src/lib.rs#L19
warning: doc list item without indentation
--> src/bundle/commitments.rs:19:5
|
19 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
19 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L21
warning: doc list item without indentation
--> src/bundle/commitments.rs:21:5
|
21 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
21 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L23
warning: doc list item without indentation
--> src/bundle/commitments.rs:23:5
|
23 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
23 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L24
warning: doc list item without indentation
--> src/bundle/commitments.rs:24:5
|
24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
| +++
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/lib.rs#L244
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/note_encryption.rs:244:18
|
244 | .zip(ephemeral_keys.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/8c27a2ba6b21f3406a51118643080f0591949827/library/core/src/iter/traits/iterator.rs:598:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
non-canonical implementation of `partial_cmp` on an `Ord` type:
src/lib.rs#L102
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> src/primitives/redpallas.rs:102:1
|
102 | / impl<T: SigType> PartialOrd for VerificationKey<T> {
103 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
104 | || <[u8; 32]>::from(self).partial_cmp(&<[u8; 32]>::from(other))
105 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
106 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/lib.rs#L195
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:195:14
|
195 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|