Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using property shapes in logical constraints #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tpluscode
Copy link
Collaborator

@tpluscode tpluscode commented Aug 6, 2024

This improves the handling of Property Shapes nested inside logical constraints, such as sh:and

@prefix sh: <http://www.w3.org/ns/shacl#> .
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@prefix schema: <http://schema.org/> .
@prefix ex: <http://example.com/> .

ex:PersonAddressShape
	a sh:NodeShape ;
	sh:targetClass schema:Person ;
	sh:property ex:ps3 .

ex:ps1	a sh:PropertyShape ;
		sh:minCount 1 .

ex:ps3	a sh:PropertyShape ;
		sh:path schema:age ;
		sh:and ( ex:ps1 ) .

By the SHACL spec, ex:ps1 is not a valid Property Shape because it lacks sh:path. However, since the Java TopQuadrant implementation handle such cases we could also try to support them

@tpluscode tpluscode requested a review from giacomociti August 6, 2024 13:28
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: f49bdc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
rdf-validate-shacl Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.80%. Comparing base (378f3db) to head (f49bdc0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   98.77%   98.80%   +0.02%     
==========================================
  Files          12       12              
  Lines        1881     1917      +36     
==========================================
+ Hits         1858     1894      +36     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant