-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Website #171
base: vue.js
Are you sure you want to change the base?
New Website #171
Conversation
feat: [wip] new home page and components
… player card, sync date, player card with team color, and update player icons to the one returned on api
✅ Deploy Preview for vry ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is incredibly impressive, thank you for taking the time to work on this. I'm going to go through the files later today and try to understand how it all works. Just a couple things, the numbers in red and green next to agent names, is that HP? If so, how often does it refresh? I like the new background but I don't want to leave it as Premier for the foreseeable future and I also don't want to be frequently changing it. Is it possible for it to reflect the map the user is playing on, preferably the loading image for the map, like this? Once again, I appreicate the PR. |
Hey, great to hear from you! So the numbers close to the agent names is the players levels. Agree with you about the background image, would be great to show the current map, but yeah also I need that information from the websocket response. So If possible return 2 new things on the websocket:
Also, if needed understanding the code you can send-me a message on discord: thurdev, and I can help with further questions. |
Can you add gun buddy? |
Yes, I just need that to be returned from the websocket aswell, not sure if already returns or not. |
As per request: #171 (comment)
Map assets added and it does already send buddies. But, adding ranks to this should require overhauling the Loadouts class to better reflect what it has now become which I do not really want to do at the moment. |
I have merged #113, which should have everything if not more in the websocket response. |
The term "Primary" also means what's defined as a "Rifle" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving explicit credit within the product is not something we have historically done. If I were a user and I clicked the GitHub button I would expect to be taken to the product's GitHub page, not a (seemingly!) random user account.
Please contact me via the Discord if you would like to work out a different arrangement.
this.inventory = {}; | ||
}, | ||
onMessage(event) { | ||
const { Players, time, map = {} } = JSON.parse(event.data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be added type checking for new request structure from #113. This pull request added more data that could be send to websocket. There is now type
field in JSON payload that can have values: heartbeat
, version
, chat
or matchLoadout
.
Don't worry, I left as a contact way, will remove it as soon as a make a new commit. |
Live preview: https://vry.thur.dev
Some screenshots and a video:
06ea923c8678956b1e346a17a208e99b.mp4
Future update Ideas: